Skip to content

Show warning on generation when leave out .url attribute for amOnPage #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
okolesnyk opened this issue Mar 22, 2018 · 3 comments
Closed

Comments

@okolesnyk
Copy link
Member

General summary

We noticed on our team after 2.1.0 release that amOnPage action previously assumed the .url attribute from the page, but then after needed to be explicitly included (all our tests failed).

Steps to reproduce

  1. Create test with amOnPage action:
    <amOnPage url="{{AdminLoginPage}}" stepKey="goToAdminLoginPage"/>
  2. Generate tests by running: vendor/bin/robo generate:tests

Expected result

  1. Warning message appears: Can not resolve argument on url attribute for amOnPage action. Step Key: "goToAdminLoginPage".

Actual result

  1. Tests successfully generated and action amOnPage looks like this:
    $I->amOnPage("{{AdminLoginPage}}");
@tomreece
Copy link
Contributor

tomreece commented Oct 7, 2019

I was able to reproduce this issue. @okolesnyk I understand we have some of these issues around for community members to tackle, but I don't like the idea of these issues sitting for so long (over a year in this case).

I would like to close this issue and create a Jira ticket instead. Are you ok with that?

@tomreece
Copy link
Contributor

tomreece commented Oct 7, 2019

Internal ticket
https://jira.corp.magento.com/browse/MQE-1799

@lbajsarowicz
Copy link
Contributor

Fixed. @tomreece & @okolesnyk - Please verify #546 PR.

@okolesnyk okolesnyk modified the milestone: 3.0.0 Feb 4, 2020
KevinBKozan added a commit that referenced this issue Mar 4, 2020
…bute

#55 Throw Exception when cannot resolve URL attribute
magento-cicd2 pushed a commit that referenced this issue Jun 23, 2021
MQE-2750: Update composer dependencies to be PHP 8 compatible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants