Fix Github Actions failure #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fascinosum
requested changes
Jul 30, 2021
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: ready for review
Progress: changes requested
labels
Remove PHP 7.2 support
Contributor
Author
|
@fascinosum, could you, please review this PR as well? |
slavvka
approved these changes
Aug 3, 2021
fascinosum
approved these changes
Aug 3, 2021
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Jan 17, 2025
AC-13728::Explicit nullable type added with PHP 8.4 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
The last Github Actions ran showed that it started failing:
https://github.com/magento/magento-semver/pull/61/checks
This PR changes how PHP is getting installed to use https://github.com/marketplace/actions/setup-php-action for installing correct PHP version.
Fixed Issues (if relevant)
Manual testing scenarios (*)
...
...
Questions or comments
Contribution checklist (*)