-
Notifications
You must be signed in to change notification settings - Fork 27
MC-38148: Validation of Approved BIC #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Display full filename for xml changes - Displa package level changes in html report - Fixed tests - Added table for package level changes - Added copy-paste button
- Code refactoring - Add helper methods to XmlRegistry
- Fixed mistakes in PackageNameResolver
- Codefixes for DbSchemaWhitelistAnalyzer
- Style fixes
- Removed redundant layout analyzer code
- Fixed handling of displaying packages within allowed change level
- Fixed namespace casing
- Fixes for Layout and DatabaseWhitelist Analyzer
- Spelling fix for docblock
- Simplify level check for packages
- Fix conditional logic
- WIP on MC-38349 - Created code for parsing contents of html - Added test cases for html
- Completed expanding db_schema cases
- Completed expanding di_xml and layout cases - Began expanding MFTF
- Completed MFTF
- Completed XSD
- use more generic pathname in tests
- Fixed issues within tests - Removed nonapi checks - Changed mftf example to patch change
- added mftf exmamples
- updated composer.lock
Contributor
Author
|
Looks like the CI/build uses php 8.0? This should be using the earliest php version in composer.json (7.2) I have added multiple people to the review, but I think one reviewer from the admin section should be sufficient. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Dec 17, 2024
Hammer platform health 30sep24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
This PR contains a collection of changes and fixes as part of the delivery for: https://jira.corp.magento.com/browse/MC-38148
Fixed Issues (if relevant)
Reviews have been performed within these tickets:
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)