Skip to content

Removed EmptyLineMissedSniff since empty lines are covered by Annotation sniffs. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2019
Merged

Removed EmptyLineMissedSniff since empty lines are covered by Annotation sniffs. #47

merged 1 commit into from
Mar 1, 2019

Conversation

@lenaorobei
Copy link
Contributor

@lenaorobei lenaorobei commented Mar 1, 2019

@lenaorobei lenaorobei requested a review from paliarush March 1, 2019 15:46
@paliarush
Copy link
Contributor

paliarush commented Mar 1, 2019

I cannot see ClassAnnotationStructureSniff in the ruleset.xml. How is it enabled?

@lenaorobei
Copy link
Contributor Author

lenaorobei commented Mar 1, 2019

@paliarush here it is https://github.com/magento/magento-coding-standard/blob/develop/Magento/ruleset.xml#L433

@lenaorobei lenaorobei merged commit df5fc07 into develop Mar 1, 2019
@lenaorobei lenaorobei deleted the Remove-EmptyLineMissedSniff branch March 11, 2019 18:13
magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 1, 2021
@svera
Merge pull request #47 from magento-commerce/imported-magento-magento…
4406251 
…-coding-standard-248

[Imported] AC-950: Create unit test for Magento2\Less\QuotesSniff check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paliarush paliarush paliarush approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Test] Unit test for EmptyLineMissedSniff

3 participants

@lenaorobei @paliarush