AC-1655: Fixed obsolete attributes not detected #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliseacornejo
previously approved these changes
Mar 30, 2022
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
sivaschenko
requested changes
Mar 30, 2022
There was a problem hiding this comment.
Thanks for the PR @svera ! Please see my comments.
Can you please execute this sniff against magento codebase and attach the results
| @@ -54,51 +53,30 @@ public function process(File $phpcsFile, $stackPtr) | |||
| ); | |||
There was a problem hiding this comment.
Please add a return after adding an error if $xml === false
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: approved
Progress: changes requested
labels
|
@sivaschenko results of the tests are ready at https://github.com/magento-lynx/magento2ce/pull/61 and https://github.com/magento-lynx/magento2ee/pull/28, both with green builds |
sivaschenko
approved these changes
Apr 1, 2022
loginesta
approved these changes
Apr 1, 2022
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the Pull Request is successfully imported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.