AC-664: Create phpcs static check for CodingStandardsIgnoreAnnotationUsageTest #257
Conversation
…UsageTest - Initial commit, copy the sniff across from magento repo
…UsageTest - Add methods register() and process()
…UsageTest - Add unit tests and update ruleset.xml
…UsageTest - Fix Typo
| { | ||
| private const CODING_STANDARDS_IGNORE_FILE = '@codingStandardsIgnoreFile'; | ||
|
|
||
| private const WARNING_CODE = self::CODING_STANDARDS_IGNORE_FILE . ' annotation must be avoided. '; |
There was a problem hiding this comment.
WARNING_CODE must be something like avoidAnnotation
| { | ||
| return []; | ||
| } | ||
| } |
| */ | ||
| public function getErrorList() | ||
| { | ||
| return []; |
There was a problem hiding this comment.
There must be an error at line 7, that's where @codingStandardsIgnoreFile is set
There was a problem hiding this comment.
I know, i set it up empty because was expecting complains on command line when running vendor/bin/phpunit.
Actually, it must be a warning.
| public function register(): array | ||
| { | ||
| return [ | ||
| T_OBJECT_OPERATOR |
There was a problem hiding this comment.
Are you sure about this operator? I think you should be looking for T_ASPERAND (the @ char) or T_COMMENT
| */ | ||
| public function process(File $phpcsFile, $stackPtr) | ||
| { | ||
| $lineContent = $phpcsFile->getTokensAsString($stackPtr, 1); |
There was a problem hiding this comment.
I don't this way will work, try to do
php$tokens = $phpcsFile->getTokens();
if (strpos($tokens[$stackPtr - 1]['content']) !== false) {
...
m2-community-project
bot
added
Progress: changes requested
Progress: review
and removed
Progress: ready for review
Progress: changes requested
labels
…UsageTest - Refactor: Fix small issues
|
This test cannot be moved to magento-coding-standard, since that’s not simply a phpunit question. |
AC-12715::Investigate the laminas composer dependencies upgrading to latest version
https://jira.corp.magento.com/browse/AC-664 Create phpcs static check for CodingStandardsIgnoreAnnotationUsageTest