Version 8 master update #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laration has trailing coma.
If a grouped use statement has a trailing coma like this:
```
use Magento\Something{
Foo,
Bar,
};
```
`findNext` on line 59 was returning false and next call was starting to search again from line 1 (`$next + 1`) and this function was looping indefinitely through input tokens.
…-coding-standard-223 [Imported] AC-957: Create unit test for Magento2\Html\HtmlDirectiveSniff check
…-coding-standard-224 [Imported] AC-958: create unit test for Magento2\Annotation checks
…-coding-standard-228 [Imported] Moved abstract unit test to autoload-dev
…-coding-standard-220 [Imported] Fix ImportsFromTestNamespace from lock on group use with trailing comma
…-coding-standard-229 [Imported] AC-939: Create unit test for Magento2\Less\AvoidIdSniff check
…-coding-standard-231 [Imported] Version 8
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
m2-community-project
bot
added
Progress: done
and removed
Progress: ready for review
labels
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 6, 2023
…ul28_2023 Arrows Team - Bugfix delivery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 8 master update
Fixed ImportsFromTestNamespace from lock on group use with trailing comma @fsw
Unit test coverage and fixes for HTML, annotation and less sniffs @eliseacornejo
Moved abstract unit test to autoload-dev @sivaschenko