Avoid infinite loop when Parse Error occurs #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihor-sviziev
approved these changes
Feb 24, 2021
m2-community-project
bot
added
Progress: approved
and removed
Progress: ready for review
labels
|
@sivaschenko @gabrieldagama @sidolov , could you take a look? This change looks good to me |
…standard into no-infinite-loop
sivaschenko
approved these changes
Jul 26, 2021
|
@magento import pr to magento-commerce/magento-coding-standard |
|
@sivaschenko the pull request successfully imported. |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Feb 1, 2023
AC-7822:Phpstan dependency should not be limited to a specific versio…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our developers introduced a Parse Error into a template file. When
phpcs --standard=Magento2ran as part of our automated testing process, it began using 100% CPU and never exited (until it was terminated automatically for taking too long). Investigation shows that the XSS Template sniff from this repository is at fault. I've managed to narrow down the cause and produced a testcase to reproduce this scenario. The proposed fix checks the return code ofPHP_CodeSniffer\Files\File::findNext(), rather than blindly assuming this is an integer. I've not searched for other uses of this function within this codebase.