Skip to content

[Test] Unit test for LiteralNamespacesSniff #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lenaorobei opened this issue Jan 11, 2019 · 1 comment · Fixed by #90
Closed

[Test] Unit test for LiteralNamespacesSniff #7

lenaorobei opened this issue Jan 11, 2019 · 1 comment · Fixed by #90
Assignees
@lenaorobei
Labels
accepted New rule is accepted enhancement Improvements to existing rules event: MageTestFest2019 MageTestFest contributions Progress: good first issue Issues is easy to get started with unit test Unit test for the rule

Comments

@lenaorobei
Copy link
Contributor

Description

LiteralNamespacesSniff needs to be covered with unit test.

Acceptance Criteria

  1. Test is added to the Magento/Tests/PHP directory and extend AbstractSniffUnitTest.
  2. Positive as well as negative scenarios are covered by unit test. In other words, LiteralNamespacesUnitTest.inc should contain "error" code as well as example of "good" code.

Additional information

See already implemented unit tests under Magento/Tests directory.
Check your code by running

$ bin/phpunit
@lenaorobei lenaorobei added the enhancement Improvements to existing rules label Jan 11, 2019
@lenaorobei lenaorobei changed the title Unit Test for LiteralNamespacesSniff Unit test for LiteralNamespacesSniff Jan 11, 2019
@lenaorobei lenaorobei added unit test Unit test for the rule accepted New rule is accepted labels Jan 11, 2019
@lenaorobei lenaorobei added the Progress: good first issue Issues is easy to get started with label Jan 29, 2019
@lenaorobei lenaorobei changed the title Unit test for LiteralNamespacesSniff [Test] Unit test for LiteralNamespacesSniff Jan 29, 2019
@centerax centerax self-assigned this Mar 8, 2019
@lenaorobei lenaorobei added the event: MageTestFest2019 MageTestFest contributions label Mar 8, 2019
@lenaorobei
Copy link
Contributor Author

@centerax hi Pablo! Do you need any assistance with this ticket?

@lenaorobei lenaorobei assigned lenaorobei and unassigned centerax Apr 24, 2019
@lenaorobei lenaorobei mentioned this issue Apr 24, 2019
Merged
mmansoor-magento pushed a commit that referenced this issue Dec 3, 2020
@sivaschenko
Merge pull request #7 from magento-commerce/imported-magento-magento-…
efc9084 
…coding-standard-201

[Imported] Version 6 master update
fredden added a commit to fredden/magento-coding-standard that referenced this issue May 24, 2021
@fredden
Fix PHP TypeError
437f8f3 
    Fatal error: Uncaught TypeError: vsprintf(): Argument magento#2 ($values) must be of type array, int given in /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php:1056
    Stack trace:
    #0 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(1056): vsprintf('Direct throw of...', 531)
    magento#1 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(706): PHP_CodeSniffer\Files\File->addMessage(false, 'Direct throw of...', 67, 4, 'FoundDirectThro...', 531, 8, false)
    magento#2 /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Exceptions/DirectThrowSniff.php(48): PHP_CodeSniffer\Files\File->addWarning('Direct throw of...', 526, 'FoundDirectThro...', 531)
    magento#3 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(498): Magento2\Sniffs\Exceptions\DirectThrowSniff->process(Object(PHP_CodeSniffer\Files\LocalFile), 526)
    magento#4 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/LocalFile.php(92): PHP_CodeSniffer\Files\File->process()
    #5 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(630): PHP_CodeSniffer\Files\LocalFile->process()
    magento#6 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(434): PHP_CodeSniffer\Runner->processFile(Object(PHP_CodeSniffer\Files\LocalFile))
    magento#7 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(114): PHP_CodeSniffer\Runner->run()
    magento#8 /srv/www/vendor/squizlabs/php_codesniffer/bin/phpcs(18): PHP_CodeSniffer\Runner->runPHPCS()
    magento#9 {main}
      thrown in /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php on line 1056
fredden added a commit to fredden/magento-coding-standard that referenced this issue Sep 2, 2021
@fredden
Fix PHP Fatal error when docblock is invalid
3fd461e 
  PHP Fatal error:  Uncaught TypeError: strpos(): Argument magento#2 ($needle) must be of type string, null given in /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php:629
  Stack trace:
  #0 /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php(629): strpos('\\VendorName\\Mod...', NULL)
  magento#1 /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php(515): Magento2\Sniffs\Annotation\MethodArgumentsSniff->validateFormattingConsistency(Array, Array, Object(PHP_CodeSniffer\Files\LocalFile), Array)
  magento#2 /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php(600): Magento2\Sniffs\Annotation\MethodArgumentsSniff->validateMethodParameterAnnotations(385, Array, Array, Object(PHP_CodeSniffer\Files\LocalFile), Array, 356, 380)
  magento#3 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/File.php(498): Magento2\Sniffs\Annotation\MethodArgumentsSniff->process(Object(PHP_CodeSniffer\Files\LocalFile), 385)
  magento#4 /srv/www/vendor/squizlabs/php_codesniffer/src/Files/LocalFile.php(92): PHP_CodeSniffer\Files\File->process()
  #5 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(630): PHP_CodeSniffer\Files\LocalFile->process()
  magento#6 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(434): PHP_CodeSniffer\Runner->processFile(Object(PHP_CodeSniffer\Files\LocalFile))
  magento#7 /srv/www/vendor/squizlabs/php_codesniffer/src/Runner.php(114): PHP_CodeSniffer\Runner->run()
  magento#8 /srv/www/vendor/squizlabs/php_codesniffer/bin/phpcs(18): PHP_CodeSniffer\Runner->runPHPCS()
  magento#9 {main}
    thrown in /srv/www/vendor/magento/magento-coding-standard/Magento2/Sniffs/Annotation/MethodArgumentsSniff.php on line 629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lenaorobei lenaorobei

Labels
accepted New rule is accepted enhancement Improvements to existing rules event: MageTestFest2019 MageTestFest contributions Progress: good first issue Issues is easy to get started with unit test Unit test for the rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added unit test for LiteralNamespaces sniff magento/magento-coding-standard
2 participants
@centerax @lenaorobei