Add --format=json option to status command #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functional Acceptance Test Results❌ One or more functional acceptance tests have failed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details. This comment was generated by Jenkins job magento-cloud-patches/functional build 102. |
PHP 7.2 Acceptance72CeCest OutputThis comment was generated by Jenkins job magento-cloud-patches/functional build 102. |
Contributor
Author
m2-community-project
bot
added
Progress: review
|
maybe @viktym can review? |
Contributor
|
@peterjaap Please merge |
Contributor
|
Hi @peterjaap |
Contributor
Author
|
@bubasuma I merged develop into my branch, should be uptodate now! |
Functional Acceptance Test Results❌ One or more functional acceptance tests have failed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details. This comment was generated by Jenkins job magento-cloud-patches/functional build 118. |
PHP 7.3 Acceptance73CeCest OutputThis comment was generated by Jenkins job magento-cloud-patches/functional build 118. |
Contributor
Author
Contributor
|
Hi @peterjaap |
viktym
reviewed
Sep 28, 2022
viktym
reviewed
Sep 28, 2022
Contributor
|
Proposed changes to Magento\CloudPatches\Command\Process\ShowStatus |
Co-authored-by: Viktor Tymchynskyi <vtymchynskyi@magento.com>
Contributor
Author
Sorry I'm not big on tests. What exactly do you want me to add there? |
Contributor
Ok, we can skip unit test for this code |
Functional Acceptance Test Results✅ All functional acceptance tests have passed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
This comment was generated by Jenkins job magento-cloud-patches/functional build 119. |
Contributor
Author
|
@viktym I've committed the changes that refactored the |
Functional Acceptance Test Results❌ One or more functional acceptance tests have failed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details. This comment was generated by Jenkins job magento-cloud-patches/functional build 120. |
PHP 7.2 Acceptance72CeCest OutputThis comment was generated by Jenkins job magento-cloud-patches/functional build 120. |
viktym
reviewed
Sep 29, 2022
src/Command/Status.php
Outdated
Comment on lines
77
to
79
| if ($input->getOption('format') !== 'json') { | ||
| $output->writeln('<info>' . $this->magentoVersion->get() . '</info>'); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($input->getOption('format') !== 'json') { | |
| $output->writeln('<info>' . $this->magentoVersion->get() . '</info>'); | |
| } | |
| if ($input->getOption('format') !== 'json') { | |
| $output->writeln('<info>' . $this->magentoVersion->get() . '</info>'); | |
| } |
@peterjaap Better to move this code to \Magento\CloudPatches\Command\Process\ShowStatus class along with \Magento\CloudPatches\Composer\MagentoVersion dependency. In this case you also need to update constructors in \Magento\CloudPatches\Test\Unit\Command\Process\ShowStatusTest and \Magento\CloudPatches\Test\Unit\Command\StatusTest
Contributor
There was a problem hiding this comment.
Thanks, please update unit tests \Magento\CloudPatches\Test\Unit\Command\Process\ShowStatusTest and \Magento\CloudPatches\Test\Unit\Command\StatusTest because currently they are failing after moving \Magento\CloudPatches\Composer\MagentoVersion dependency
Contributor
Author
There was a problem hiding this comment.
No thanks. You can do it if you'd like, you were the one that suggested the change.
I'll just close this PR otherwise, it has taken me too much time already for such a little feature.
And people wonder why it takes ages to merge something into the Magento codebase...
Contributor
There was a problem hiding this comment.
@peterjaap no problem, I can help you with the unit tests update. It's not about Magento, you will not be able to merge a PR to any other OS project with red builds. The requirement for test coverage is in DoD (definition of done), sorry.
Please check PR peterjaap#1
… of Status command
Functional Acceptance Test Results✅ All functional acceptance tests have passed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
This comment was generated by Jenkins job magento-cloud-patches/functional build 121. |
viktym
reviewed
Sep 30, 2022
Co-authored-by: Viktor Tymchynskyi <vtymchynskyi@magento.com>
Functional Acceptance Test Results✅ All functional acceptance tests have passed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
This comment was generated by Jenkins job magento-cloud-patches/functional build 122. |
- Update unit tests after moving MagentoVersion dependency
Contributor
Author
|
@viktym thanks!! I merged your PR into my branch. |
Functional Acceptance Test Results✅ All functional acceptance tests have passed. PHP 7.2
PHP 7.3
PHP 7.4
PHP 8.1
This comment was generated by Jenkins job magento-cloud-patches/functional build 123. |
Contributor
|
@peterjaap thanks for your contribution. This PR will be processed and the code changes will be available in the next |
viktym
approved these changes
Oct 14, 2022
Contributor
|
@viktym the Pull Request is successfully imported. |
m2-community-project
bot
added
Progress: done
and removed
Progress: review
Contributor
|
It will be in the next release MCP 1.0.20 |
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Sep 13, 2023
MCLOUD-11149: MCP Release 1.0.24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
--format=jsonto thevendor/bin/magento-patches statuscommand.This allows us to automate stuff concerning these patches better in our CI/CD deployments.
Contribution checklist