Restrict patch from being applied to version 2.4.3-p2. Since it's bee… #85

leonhelmus · 2022-04-25T11:42:49Z

…n resolved in the patch it self.

For more information see:

2.4.3-p2 missing patches MDVA-43395_EE_2.4.3-p1_COMPOSER_v1.patch & MDVA-43443_EE_2.4.3-p1_COMPOSER_v1.patch magento2#35341

Description

Magento cloud patches apply a patch that has been resolved in magento 2.4.3-p2. According to @nathanjosiah.

Fixed Issues (if relevant)

Patch MDVA-43443__parser_token_new_fix__2.4.3.patch is not applied for 2.4.3-p2.

Associated documentation updates

magento/magento2#35341

Contribution checklist

Pull request has a meaningful description of its purpose
Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)

…n resolved in the patch it self. For more information see: * magento/magento2#35341

magento-cloud-ft-jenkins-svc · 2022-04-25T14:26:42Z

Functional Acceptance Test Results

❌ One or more functional acceptance tests have failed.

PHP 7.2

❌ Acceptance72CeCest
❌ Acceptance72Cest

PHP 7.3

✅ Acceptance73CeCest
✅ Acceptance73Cest

PHP 7.4

✅ Acceptance74CeCest
✅ Acceptance74Cest

PHP 8.1

✅ AcceptanceCest
✅ PatchApplierCest

Output for failed tests is below. If many tests have failed only the first 5 will be included. If you need additional information please reach out to the Magento Cloud team for more details.

This comment was generated by Jenkins job magento-cloud-patches/functional build 100.

magento-cloud-ft-jenkins-svc · 2022-04-25T14:26:43Z

PHP 7.2 Acceptance72CeCest Output

Codeception PHP Testing Framework v4.1.31 https://helpukrainewin.org
Powered by PHPUnit 8.5.26 #StandWithUkraine

Acceptance Tests (4) ---------------------------------------
Acceptance72CeCest: Test patches | "2.3.0"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72CeCest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72CeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.0"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I get work dir path 
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/p...",">=2.3.0 <..."
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(55): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2924): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1568): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/lib-asserts/src/Codeception/Util/Shared/InheritedAsserts.php(1380): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 [internal function]: Codeception\Module\AbstractAsserts->assertTrue(false)
#5 /app/vendor/codeception/codeception/src/Codeception/Step.php(285): call_user_func_array(Array, Array)
#6 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(76): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#7 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(5253): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#8 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(37): CliTester->assertTrue(false)
#9 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#10 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(128): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72CeCest), Array)
#11 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72CeCest), 'testPatches', Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(98): Codeception\Test\Cest->test()
#15 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(626): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#16 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(117): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(161): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#18 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(208): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(162): Codeception\Codecept->runSuite(Array, 'Acceptance', 'Acceptance72CeC...')
#20 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(403): Codeception\Codecept->run('Acceptance', 'Acceptance72CeC...', Array)
#21 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#22 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/codeception/codeception/src/Codeception/Application.php(117): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/app.php(46): Codeception\Application->run()
#27 /app/vendor/codeception/codeception/app.php(47): {closure}()
#28 /app/vendor/codeception/codeception/codecept(7): require('/app/vendor/cod...')
#29 {main}
------------------------------------
Acceptance72CeCest: Test patches | "2.3.1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72CeCest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72CeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.1"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I get work dir path 
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/p...",">=2.3.1 <..."
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

Acceptance72CeCest: Test patches | "2.3.2","2.3.2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72CeCest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72CeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-c...","2.3.2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

Acceptance72CeCest: Test patches | "2.3.2","2.3.2-p2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72CeCest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72CeCest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.3.2-p2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

------------------------------------------------------------
81x DEPRECATION: Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell. /app/vendor/symfony/process/Process.php:147
44x DEPRECATION: The Robo\Common\ProcessUtils::escapeArgument() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0. /app/vendor/consolidation/robo/src/Common/ProcessUtils.php:39


Time: 22.95 minutes, Memory: 24.00 MB

There was 1 failure:

---------
1) Acceptance72CeCest: Test patches | "2.3.0"
 Test  src/Test/Functional/Acceptance/Acceptance72CeCest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 33. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:99
 32. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:98
 31. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:37
 30. $I->runDockerComposeCommand("run build cloud-build") at src/Test/Functional/Acceptance/AcceptanceCest.php:37
 29. $I->generateDockerCompose("--mode=production --env...") at src/Test/Functional/Acceptance/AcceptanceCest.php:35
 28. $I->copyFileToWorkDir("files/patc...",".magento.e...") at src/Test/Functional/Acceptance/AcceptanceCest.php:32


FAILURES!
Tests: 4, Assertions: 35, Failures: 1.
- XML report generated in file:///app/tests/functional/_output/junit.xml

This comment was generated by Jenkins job magento-cloud-patches/functional build 100.

magento-cloud-ft-jenkins-svc · 2022-04-25T14:26:44Z

PHP 7.2 Acceptance72Cest Output

Codeception PHP Testing Framework v4.1.31 https://helpukrainewin.org
Powered by PHPUnit 8.5.26 #StandWithUkraine

Acceptance Tests (4) ---------------------------------------
Acceptance72Cest: Test patches | "2.3.0"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72Cest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72Cest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.0"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true false
 I stop environment 
 I remove work dir 
 FAIL 

------------------------------------
Message: Failed asserting that false is true.
------------------------------------
Stack Trace: 
#0 /app/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php(55): PHPUnit\Framework\Constraint\Constraint->fail(false, '')
#1 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(2924): PHPUnit\Framework\Constraint\Constraint->evaluate(false, '')
#2 /app/vendor/phpunit/phpunit/src/Framework/Assert.php(1568): PHPUnit\Framework\Assert::assertThat(false, Object(PHPUnit\Framework\Constraint\IsTrue), '')
#3 /app/vendor/codeception/lib-asserts/src/Codeception/Util/Shared/InheritedAsserts.php(1380): PHPUnit\Framework\Assert::assertTrue(false, '')
#4 [internal function]: Codeception\Module\AbstractAsserts->assertTrue(false)
#5 /app/vendor/codeception/codeception/src/Codeception/Step.php(285): call_user_func_array(Array, Array)
#6 /app/vendor/codeception/codeception/src/Codeception/Scenario.php(76): Codeception\Step->run(Object(Codeception\Lib\ModuleContainer))
#7 /app/vendor/magento/magento-cloud-docker/tests/functional/_support/_generated/CliTesterActions.php(5253): Codeception\Scenario->runStep(Object(Codeception\Step\Action))
#8 /app/src/Test/Functional/Acceptance/AcceptanceCest.php(37): CliTester->assertTrue(false)
#9 [internal function]: Magento\CloudPatches\Test\Functional\Acceptance\AcceptanceCest->testPatches(Object(CliTester), Object(Codeception\Example))
#10 /app/vendor/codeception/codeception/src/Codeception/Lib/Di.php(128): ReflectionMethod->invokeArgs(Object(Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72Cest), Array)
#11 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(138): Codeception\Lib\Di->injectDependencies(Object(Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72Cest), 'testPatches', Array)
#12 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(147): Codeception\Test\Cest->invoke('testPatches', Array)
#13 /app/vendor/codeception/codeception/src/Codeception/Test/Cest.php(82): Codeception\Test\Cest->executeTestMethod(Object(CliTester))
#14 /app/vendor/codeception/codeception/src/Codeception/Test/Test.php(98): Codeception\Test\Cest->test()
#15 /app/vendor/phpunit/phpunit/src/Framework/TestSuite.php(626): Codeception\Test\Test->run(Object(PHPUnit\Framework\TestResult))
#16 /app/vendor/codeception/phpunit-wrapper/src/Runner.php(117): PHPUnit\Framework\TestSuite->run(Object(PHPUnit\Framework\TestResult))
#17 /app/vendor/codeception/codeception/src/Codeception/SuiteManager.php(161): Codeception\PHPUnit\Runner->doEnhancedRun(Object(Codeception\Suite), Object(PHPUnit\Framework\TestResult), Array)
#18 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(208): Codeception\SuiteManager->run(Object(Codeception\PHPUnit\Runner), Object(PHPUnit\Framework\TestResult), Array)
#19 /app/vendor/codeception/codeception/src/Codeception/Codecept.php(162): Codeception\Codecept->runSuite(Array, 'Acceptance', 'Acceptance72Ces...')
#20 /app/vendor/codeception/codeception/src/Codeception/Command/Run.php(403): Codeception\Codecept->run('Acceptance', 'Acceptance72Ces...', Array)
#21 /app/vendor/symfony/console/Command/Command.php(255): Codeception\Command\Run->execute(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#22 /app/vendor/symfony/console/Application.php(1009): Symfony\Component\Console\Command\Command->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#23 /app/vendor/symfony/console/Application.php(273): Symfony\Component\Console\Application->doRunCommand(Object(Codeception\Command\Run), Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#24 /app/vendor/symfony/console/Application.php(149): Symfony\Component\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#25 /app/vendor/codeception/codeception/src/Codeception/Application.php(117): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#26 /app/vendor/codeception/codeception/app.php(46): Codeception\Application->run()
#27 /app/vendor/codeception/codeception/app.php(47): {closure}()
#28 /app/vendor/codeception/codeception/codecept(7): require('/app/vendor/cod...')
#29 {main}
------------------------------------
Acceptance72Cest: Test patches | "2.3.1"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72Cest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72Cest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.1"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

Acceptance72Cest: Test patches | "2.3.2","2.3.2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72Cest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72Cest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/product-e...","2.3.2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

Acceptance72Cest: Test patches | "2.3.2","2.3.2-p2"
Signature: Magento\CloudPatches\Test\Functional\Acceptance\Acceptance72Cest:testPatches
Test: src/Test/Functional/Acceptance/Acceptance72Cest.php:testPatches
Scenario --
 I cleanup work dir 
 I clone template to work dir "2.3.2"
 I create auth json 
 I create artifacts dir 
 I create artifact current tested code "patches","1.0.99"
 I add artifacts repo to composer 
 I add dependency to composer "magento/magento-...","1.0.99"
 I add ece docker git repo to composer 
 I add quality patches git repo to composer 
 I add ece tools git repo to composer 
 I add cloud components git repo to composer 
 I get dependency version "magento/magento-cloud-docker"
 I add dependency to composer "magento/m...","dev-devel..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/magento-cloud-components"
 I add dependency to composer "magento/m...","1.0.x-dev..."
 I assert true true,"Can not add dependency magento/mage..."
 I get dependency version "magento/quality-patches"
 I add dependency to composer "magento/q...","dev-maste..."
 I assert true true,"Can not add dependency magento/qual..."
 I get dependency version "magento/ece-tools"
 I add dependency to composer "magento/e...","dev-devel..."
 I assert true true,"Can not add dependency magento/ece-..."
 I remove dependency from composer "magento/magento-clou..."
 I add dependency to composer "magento/produc...","2.3.2-p2"
 I composer update 
 I copy file to work dir "files/patche...",".magento.env..."
 I generate docker compose "--mode=production --env-vars..."
 I run docker compose command "run build cloud-build"
 I assert true true
 I start environment 
 I assert true true
 I run docker compose command "run deploy cloud-deploy"
 I assert true true
 I run docker compose command "run deploy cloud-post-deploy"
 I assert true true
 I am on page "/"
 I see "Home page"
 I see "CMS homepage content goes here."
 I stop environment 
 I remove work dir 
 PASSED 

------------------------------------------------------------
77x DEPRECATION: Passing a command as string when creating a "Symfony\Component\Process\Process" instance is deprecated since Symfony 4.2, pass it as an array of its arguments instead, or use the "Process::fromShellCommandline()" constructor if you need features provided by the shell. /app/vendor/symfony/process/Process.php:147
42x DEPRECATION: The Robo\Common\ProcessUtils::escapeArgument() method is a copy of a method that was deprecated by Symfony 3.3 and removed in Symfony 4; it will be removed in Robo 2.0. /app/vendor/consolidation/robo/src/Common/ProcessUtils.php:39


Time: 25.94 minutes, Memory: 24.00 MB

There was 1 failure:

---------
1) Acceptance72Cest: Test patches | "2.3.0"
 Test  src/Test/Functional/Acceptance/Acceptance72Cest.php:testPatches
 Step  Assert true false
 Fail  Failed asserting that false is true.

Scenario Steps:

 30. $I->removeWorkDir() at src/Test/Functional/Acceptance/AbstractCest.php:99
 29. $I->stopEnvironment() at src/Test/Functional/Acceptance/AbstractCest.php:98
 28. $I->assertTrue(false) at src/Test/Functional/Acceptance/AcceptanceCest.php:37
 27. $I->runDockerComposeCommand("run build cloud-build") at src/Test/Functional/Acceptance/AcceptanceCest.php:37
 26. $I->generateDockerCompose("--mode=production --env...") at src/Test/Functional/Acceptance/AcceptanceCest.php:35
 25. $I->copyFileToWorkDir("files/patc...",".magento.e...") at src/Test/Functional/Acceptance/AcceptanceCest.php:32


FAILURES!
Tests: 4, Assertions: 35, Failures: 1.
- XML report generated in file:///app/tests/functional/_output/junit.xml

This comment was generated by Jenkins job magento-cloud-patches/functional build 100.

leonhelmus · 2022-04-25T14:30:33Z

I cannot resolve this issue for php7.2 in my opinion. Could someone check it?

leonhelmus · 2022-04-25T16:15:45Z

@BarnyShergold i saw you were a pr of the previous merge. Could you look into this? I think it's important otherwise all cloud project will have a patch that should not be applied from @nathanjosiah

BarnyShergold · 2022-04-25T16:22:54Z

@BarnyShergold i saw you were a pr of the previous merge. Could you look into this? I think it's important otherwise all cloud project will have a patch that should not be applied from @nathanjosiah
Not sure which merge you are referring to? Please can you provide a link and clarify what you want me to look into? Cheers

leonhelmus · 2022-04-25T17:02:56Z

@BarnyShergold the functional check doesnt seem to work for php7.2. While i dont think i did anything wrong. I just wanted to bring this too urgent notice and with the last merge i mean a previous pr that was merged in this repository. Also you helped me last time i created an pr for ece-tools. Thats why i asked you 😁.

The constraint that i changed is from smaller than 2.4.3-p3 to smaller than 2.4.3-p2 is necessary. Nathan confirmed to me that this patch must not be applied for magento projects that are on 2.4.3-p2. Since it was resolved in a different way in 2.4.3-p2. I think this issue has a high priority because it must not be applied for magento 2.4.3-p2 cloud projects, while it does now. So everyone that now updates to 2.4.3-p2 will have a wrong patch added to their shop. For more info about this patch see magento/magento2#35341

Hope this clarifies my issues. Also cant seem to add any assignees to check this pr.

BarnyShergold · 2022-04-26T08:36:15Z

@BarnyShergold the functional check doesnt seem to work for php7.2. While i dont think i did anything wrong. I just wanted to bring this too urgent notice and with the last merge i mean a previous pr that was merged in this repository. Also you helped me last time i created an pr for ece-tools. Thats why i asked you 😁.

The constraint that i changed is from smaller than 2.4.3-p3 to smaller than 2.4.3-p2 is necessary. Nathan confirmed to me that this patch must not be applied for magento projects that are on 2.4.3-p2. Since it was resolved in a different way in 2.4.3-p2. I think this issue has a high priority because it must not be applied for magento 2.4.3-p2 cloud projects, while it does now. So everyone that now updates to 2.4.3-p2 will have a wrong patch added to their shop. For more info about this patch see magento/magento2#35341

Hope this clarifies my issues. Also cant seem to add any assignees to check this pr.

I'm afraid I can't help you with the functional tests - it won't say why it's failed and I can't see any reason . I'll see if it possible to re-run but you'll have to wait for one of the main people to review.

BarnyShergold · 2022-04-26T08:36:31Z

@magento run Functional Tests

leonhelmus · 2022-04-29T08:48:01Z

Could anyone look at this i think it's pretty important.

hostep · 2022-04-29T12:14:37Z

In the line above the line you modified, the version should probably also be changed from <2.3.7-p4 to <2.3.7-p3, no? @nathanjosiah can maybe confirm?

BaDos · 2022-04-29T15:09:20Z

Hi @leonhelmus
Thank you for your contribution.
I'm going to process this PR.
FT was fixed yesterday.

m2-github-services · 2022-04-29T15:11:29Z

@BaDos the Pull Request is successfully imported.

m2-github-services · 2022-04-29T15:12:27Z

@BaDos an error occurred during the Pull Request import.

leonhelmus · 2022-05-01T19:11:47Z

When will the tag 1.0.17 be available?

leonhelmus · 2022-05-02T12:44:59Z

@BaDos I really want to update to 1.0.17

leonhelmus · 2022-05-03T07:38:13Z

@nathanjosiah Could someone make the tag available?

BaDos · 2022-05-24T19:56:58Z

@leonhelmus https://github.com/magento/magento-cloud-patches/tree/1.0.17
also, repo.magento.com has this version

leonhelmus · 2022-06-16T07:44:34Z

@BaDos thanks for the update :). This will prevent other people from applying the patch.

Bump version to 1.0.24

Restrict patch from being applied to version 2.4.3-p2. Since it's bee…

69e8b44

…n resolved in the patch it self. For more information see: * magento/magento2#35341

m2-community-project bot added the Progress: ready for review label Apr 25, 2022

magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 30, 2022

MCLOUD-8720: Process the MCP PR #85

b66884b

magento-devops-reposync-svc merged commit 69e8b44 into magento:develop Apr 30, 2022

m2-community-project bot added Progress: done and removed Progress: ready for review labels Apr 30, 2022

magento-devops-reposync-svc pushed a commit that referenced this pull request Sep 12, 2023

Merge pull request #85 from magento-commerce/bump-version-to-1.0.24

bdb763c

Bump version to 1.0.24

andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025

MCLOUD-8720: Process the MCP PR #85

9ea4329

andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025

Merge pull request #85 from magento-commerce/bump-version-to-1.0.24

7aabd87

Bump version to 1.0.24

Restrict patch from being applied to version 2.4.3-p2. Since it's bee… #85

Restrict patch from being applied to version 2.4.3-p2. Since it's bee… #85

Uh oh!

Conversation

leonhelmus commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixed Issues (if relevant)

Associated documentation updates

Contribution checklist

Uh oh!

magento-cloud-ft-jenkins-svc commented Apr 25, 2022

Functional Acceptance Test Results

PHP 7.2

PHP 7.3

PHP 7.4

PHP 8.1

Uh oh!

magento-cloud-ft-jenkins-svc commented Apr 25, 2022

PHP 7.2 Acceptance72CeCest Output

Uh oh!

magento-cloud-ft-jenkins-svc commented Apr 25, 2022

PHP 7.2 Acceptance72Cest Output

Uh oh!

leonhelmus commented Apr 25, 2022

Uh oh!

leonhelmus commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BarnyShergold commented Apr 25, 2022

Uh oh!

leonhelmus commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BarnyShergold commented Apr 26, 2022

Uh oh!

BarnyShergold commented Apr 26, 2022

Uh oh!

leonhelmus commented Apr 29, 2022

Uh oh!

hostep commented Apr 29, 2022

Uh oh!

BaDos commented Apr 29, 2022

Uh oh!

m2-github-services commented Apr 29, 2022

Uh oh!

m2-github-services commented Apr 29, 2022

Uh oh!

leonhelmus commented May 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

leonhelmus commented May 2, 2022

Uh oh!

leonhelmus commented May 3, 2022

Uh oh!

BaDos commented May 24, 2022

Uh oh!

leonhelmus commented Jun 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

leonhelmus commented Apr 25, 2022 •

edited

Loading

leonhelmus commented Apr 25, 2022 •

edited

Loading

leonhelmus commented Apr 25, 2022 •

edited

Loading

leonhelmus commented May 1, 2022 •

edited

Loading