Skip to content

Conversation

@viktym
Copy link
Contributor

@viktym viktym commented Sep 7, 2020

Description

Refactor extensibility approach for magento-cloud-patches & quality-patches to eliminate circular dependency between packages:

  • Add magento/quality-patches to 'require' section of composer.json for magento/ece-tools
  • Move magento/quality-patches to 'suggest' section of composer.json for magento/magento-cloud-patches

Fixed Issues (if relevant)

MC-37292: Make 'quality-patches' a hard dependency for ece-tools and soft dependency for magento-cloud-patches

Related PR

Manual testing scenarios

  1. ...
  2. ...

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Patches release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@BarnyShergold
Copy link

@magento run all tests

@BarnyShergold
Copy link

Approving - can't see why the tests are failing

@BaDos
Copy link
Contributor

BaDos commented Sep 8, 2020

See this PR #76

@BaDos BaDos closed this Sep 8, 2020
@bubasuma bubasuma deleted the MC-37292 branch September 17, 2020 21:35
magento-devops-reposync-svc pushed a commit that referenced this pull request Jun 14, 2023
MCLOUD-10604: Added ACSD-51892 patch
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
MCLOUD-10604: Added ACSD-51892 patch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants