Skip to content

Conversation

@rganin
Copy link

@rganin rganin commented Aug 4, 2020

Description

https://jira.corp.magento.com/browse/MCLOUD-6682:
Patch for https://jira.corp.magento.com/browse/B2B-716

Fixed Issues (if relevant)

  1. https://jira.corp.magento.com/browse/B2B-716

Manual testing scenarios

  1. ...
  2. ...

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Patches release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@@ -0,0 +1,21 @@
diff --git a/vendor/magento/module-purchase-order/Setup/Patch/Data/InitPurchaseOrderSalesSequence.php b/vendor/magento/module-purchase-order/Setup/Patch/Data/InitPurchaseOrderSalesSequence.php
index c8acaa346..6579e8812 100644
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove redundant index

Copy link
Contributor

@NadiyaS NadiyaS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this patch to patches.json

">=2.2.0 <2.3.2": "MAGECLOUD-4071__terminate_consumers_if_the_queue_is_empty__2.2.0.patch"
},
"Fix of upgrade issue for b2b instances with more than 1 store": {
"2.4.0": "B2B-716-Exception_thrown_during_upgrade_when_installing_B2B_2.4.0.patch"
Copy link
Contributor

@NadiyaS NadiyaS Aug 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use double underscore after ticket number and after name
So the name of patch should look like
B2B-716__exception_thrown_during_upgrade_when_installing_B2B__2.4.0.patch

@mveeramneni mveeramneni changed the title B2B-716: Exception thrown during setup:upgrade when installing B2B MCLOUD-6682: B2B-716: Exception thrown during setup:upgrade when installing B2B Aug 9, 2020
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper description to the PR - A link to a Magento JIRA ticket can't be used as many Maintainers don't have access to the JIRA instance.

@shiftedreality
Copy link
Member

@rganin please address highlighted issues

@shiftedreality shiftedreality changed the title MCLOUD-6682: B2B-716: Exception thrown during setup:upgrade when installing B2B B2B-716: Exception thrown during setup:upgrade when installing B2B Aug 10, 2020
@shiftedreality
Copy link
Member

@rganin please re-open this PR once it's ready for review

@mveeramneni mveeramneni changed the title B2B-716: Exception thrown during setup:upgrade when installing B2B /MCLOUD-6683B2B-716: Exception thrown during setup:upgrade when installing B2B Aug 31, 2020
@mveeramneni mveeramneni changed the title /MCLOUD-6683B2B-716: Exception thrown during setup:upgrade when installing B2B MCLOUD-6682: B2B-716: Exception thrown during setup:upgrade when installing B2B Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants