-
Notifications
You must be signed in to change notification settings - Fork 34
MCLOUD-6682: B2B-716: Exception thrown during setup:upgrade when installing B2B #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @@ -0,0 +1,21 @@ | |||
| diff --git a/vendor/magento/module-purchase-order/Setup/Patch/Data/InitPurchaseOrderSalesSequence.php b/vendor/magento/module-purchase-order/Setup/Patch/Data/InitPurchaseOrderSalesSequence.php | |||
| index c8acaa346..6579e8812 100644 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove redundant index
NadiyaS
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this patch to patches.json
| ">=2.2.0 <2.3.2": "MAGECLOUD-4071__terminate_consumers_if_the_queue_is_empty__2.2.0.patch" | ||
| }, | ||
| "Fix of upgrade issue for b2b instances with more than 1 store": { | ||
| "2.4.0": "B2B-716-Exception_thrown_during_upgrade_when_installing_B2B_2.4.0.patch" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use double underscore after ticket number and after name
So the name of patch should look like
B2B-716__exception_thrown_during_upgrade_when_installing_B2B__2.4.0.patch
BarnyShergold
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add proper description to the PR - A link to a Magento JIRA ticket can't be used as many Maintainers don't have access to the JIRA instance.
|
@rganin please address highlighted issues |
|
@rganin please re-open this PR once it's ready for review |
Description
https://jira.corp.magento.com/browse/MCLOUD-6682:
Patch for https://jira.corp.magento.com/browse/B2B-716
Fixed Issues (if relevant)
Manual testing scenarios
Release notes
For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Patches release notes.
Associated documentation updates
Add link to Magento DevDocs PR or Issue, if needed.
Contribution checklist