Skip to content

BUNDLE-2683: VBE Braintree - Error occurs in Admin Braintree Settlement Report #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 12, 2020
Merged

BUNDLE-2683: VBE Braintree - Error occurs in Admin Braintree Settlement Report #64

merged 9 commits into from
Aug 12, 2020

Conversation

@magterskine
Copy link
Contributor

@magterskine magterskine commented Jul 29, 2020 •
edited by mveeramneni
Loading

Description:

https://jira.corp.magento.com/browse/MCLOUD-6684:
Adds patch to fix issue for Braintree VBE where Admin viewing Braintree Settlement Report causes error screen

Fixed Issues:

https://jira.corp.magento.com/browse/BUNDLE-2683

Manual Testing Scenarios

  1. Enable Braintree
  2. Navigate to: Magento Admin Panel > Reports > Braintree Settlement
  3. “Braintree Settlement Report” page should be loaded

@BarnyShergold BarnyShergold self-assigned this Jul 30, 2020
BarnyShergold
BarnyShergold suggested changes Jul 30, 2020
View reviewed changes
Copy link

@BarnyShergold BarnyShergold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The is no proper description for the PR - please add one with correct format and full description
Tests are failing
PR name has type (BUNDLE not BUNLDE)

@viktym
Copy link
Contributor

viktym commented Jul 30, 2020

Please, fix patch filename (use __ after ticket number and before the version):

ERROR: The command "php ./vendor/bin/ece-patches apply --no-interaction" failed.                                                                                                     
  [Magento\CloudPatches\Patch\Collector\CollectorException]                                         
  The patch filename 'BUNDLE-2683_braintree_settlement_report_fix_4.1.0.patch' has invalid format.  
  Correct format: <TICKET_NUMBER>__<TITLE>__<PACKAGE_VERSION>.patch                                 
  Example: MAGECLOUD-2899__fix_redis_slave_configuration__2.3.0.patch

@magterskine magterskine changed the title Patch for BUNLDE-2683 BUNDLE-2683- VBE Braintree - Error occurs in Admin Braintree Settlement Report Jul 30, 2020
@shiftedreality
Copy link
Member

shiftedreality commented Jul 30, 2020

@viktym @magterskine please re-create this PR into https://github.com/magento/quality-patches

@shiftedreality shiftedreality added Progress: review PR/issue status and removed Progress: review PR/issue status labels Jul 30, 2020
shiftedreality
shiftedreality suggested changes Aug 4, 2020
View reviewed changes
@shiftedreality shiftedreality changed the title BUNDLE-2683- VBE Braintree - Error occurs in Admin Braintree Settlement Report BUNDLE-2683: VBE Braintree - Error occurs in Admin Braintree Settlement Report Aug 4, 2020
NadiyaS
NadiyaS previously approved these changes Aug 4, 2020
View reviewed changes
oshmyheliuk
oshmyheliuk suggested changes Aug 10, 2020
View reviewed changes
@shiftedreality shiftedreality changed the title MCLOUD-6684: BUNDLE-2683: VBE Braintree - Error occurs in Admin Braintree Settlement Report BUNDLE-2683: VBE Braintree - Error occurs in Admin Braintree Settlement Report Aug 11, 2020
@mveeramneni
Copy link

mveeramneni commented Aug 11, 2020

QA Approved

@shiftedreality shiftedreality merged commit b8eb1fb into develop Aug 12, 2020
@shiftedreality shiftedreality deleted the BUNDLE-2683 branch August 12, 2020 16:39
@m2-community-project m2-community-project bot removed the Progress: approved PR/issue status label Aug 12, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 17, 2022
@BaDos
MCLOUD-7845: Add MCLOUD-7205(MCP-103) to magento-cloud-patches (#64)
138c65e
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@magterskine
BUNDLE-2683: VBE Braintree - Error occurs in Admin Braintree Settleme…
5628cde 
…nt Report (#64)
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@BaDos
MCLOUD-7845: Add MCLOUD-7205(MCP-103) to magento-cloud-patches (#64)
b22db5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@BarnyShergold BarnyShergold BarnyShergold approved these changes

@shiftedreality shiftedreality shiftedreality approved these changes

@NadiyaS NadiyaS NadiyaS approved these changes

@oshmyheliuk oshmyheliuk oshmyheliuk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BarnyShergold BarnyShergold

@shiftedreality shiftedreality

@NadiyaS NadiyaS

@oshmyheliuk oshmyheliuk

@magterskine magterskine

@mveeramneni mveeramneni

Labels

Release: 1.0.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@magterskine @viktym @shiftedreality @mveeramneni @BarnyShergold @NadiyaS @oshmyheliuk @meker12 @BaDos