Skip to content

MCLOUD-6588: Remove amazon patches from magento2-base component #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2020
Merged

MCLOUD-6588: Remove amazon patches from magento2-base component #63

merged 3 commits into from
Jul 30, 2020

Conversation

@NadiyaS
Copy link
Contributor

@NadiyaS NadiyaS commented Jul 28, 2020 •
edited
Loading

Description

Fixed Issues (if relevant)

  1. patch for amzn/amazon-pay-module exist for magento2-base
  2. build fails when patched module is not in the project #51

Manual testing scenarios

  1. Check that amazon patches are applyed for next versions:
  • Magento 2.2.6. - patch MAGECLOUD-2850__fix_amazon_payment_module__2.2.6.patch
  • Magento 2.3.5 - patch BUNDLE-2554__set_payment_info_bug_fix__3.4.1.patch
  1. after removing amzn/amazon-pay-module or amzn/amazon-pay-and-login-magento-2-module patches should not be applied and deploy finishes without error

Release notes

For user-facing changes, add a meaningful release note. For examples, see Magento Cloud Patches release notes.

Associated documentation updates

Add link to Magento DevDocs PR or Issue, if needed.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • Pull request introduces user-facing changes and includes meaningful updates for any required release notes and documentation changes
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)

@BarnyShergold BarnyShergold self-assigned this Jul 28, 2020
@mveeramneni mveeramneni added the Progress: review PR/issue status label Jul 29, 2020
@mveeramneni mveeramneni self-assigned this Jul 30, 2020
@mveeramneni
Copy link

mveeramneni commented Jul 30, 2020

QA Approved

@oshmyheliuk oshmyheliuk merged commit aaaa16d into develop Jul 30, 2020
@oshmyheliuk oshmyheliuk deleted the MCLOUD-6588 branch July 30, 2020 17:28
@meker12 meker12 mentioned this pull request Jul 30, 2020
Closed
magento-devops-reposync-svc pushed a commit that referenced this pull request Oct 14, 2022
@BaDos
Merge pull request #63 from magento-commerce/imported-peterjaap-magen…
aa71556 
…to-cloud-patches-86
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@NadiyaS
MCLOUD-6588: Remove amazon patches from magento2-base component (#63)
64dc2b0
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@BaDos
Merge pull request #63 from magento-commerce/imported-peterjaap-magen…
73d1cac 
…to-cloud-patches-86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@oshmyheliuk oshmyheliuk oshmyheliuk approved these changes

@billygilbert billygilbert billygilbert approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@BarnyShergold BarnyShergold

@mveeramneni mveeramneni

Labels

Progress: approved PR/issue status Release: 1.0.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@NadiyaS @mveeramneni @oshmyheliuk @billygilbert @BarnyShergold @YPyltiai