MCLOUD-5930: BUNDLE-2554: [Amazon Pay] Unable to switch credit card during checkout #42
Conversation
- patch for BUNDLE-2554 fix for Amazon-pay VBE v3.4.1 on M2.3.5
|
|
||
| $responseParser = $this->clientFactory->create($storeId)->setOrderReferenceDetails($data); | ||
| - try { | ||
| - $response = $this->amazonSetOrderDetailsResponseFactory->create( |
There was a problem hiding this comment.
@BarnyShergold those lines are deleted. In patches need to pay attention to those which have + sign at the beginning, so only those line will exist after patch applying
| - } catch (AmazonServiceUnavailableException $e) { | ||
| - if($e->getApiErrorCode() == 'OrderReferenceNotModifiable') { | ||
| - $this->logger->warning( | ||
| - "Could not modify Amazon order details for $amazonOrderReferenceId: " |
There was a problem hiding this comment.
Don't embed variables in strings. Use single quotes and concatenate or use sprintf
There was a problem hiding this comment.
This is a fix for 3rd-party extension, can be ignored in favor of the original change
| + /** | ||
| + * @return boolean | ||
| + */ | ||
| + protected function canConfirmOrderReference() |
There was a problem hiding this comment.
This is a fix for 3rd-party extension, can be ignored in favor of the original change
|
Patch is for Amazon-pay bundled extension. This extension is also available via Amazons Github page which has future versions published (i.e. later than Magento bundles). We can not makes the changes suggested above as this will break compatibility/versioning. |
patches.json
Outdated
| }, | ||
| "amzn/amazon-pay-and-login-magento-2-module": { | ||
| "Set Payment info bug": { | ||
| "3.4.1": "BUNDLE-2554__set_payment_info_bug_fix__3.4.1" |
There was a problem hiding this comment.
Why this fix is only for 3.4.1?
I still see the same code in 3.4.2 https://github.com/amzn/amazon-payments-magento-2-plugin/blob/3.4.2/src/Payment/Model/OrderInformationManagement.php#L148
Where only 3.4.3 has this fix - https://github.com/amzn/amazon-payments-magento-2-plugin/blob/3.4.3/src/Payment/Model/OrderInformationManagement.php#L147
There was a problem hiding this comment.
And add extension to the patch file
BUNDLE-2554__set_payment_info_bug_fix__3.4.1.patch.
There was a problem hiding this comment.
3.4.1 is the version that will be bundled with Magento 2.3.5 - we do not at this point bundle 3.4.2 - and given this bug, when we increment the version of Amazon-pay that we bundle in future release, it will be at least 3.4.3 or greater which contains this fix
There was a problem hiding this comment.
And add extension to the patch file
BUNDLE-2554__set_payment_info_bug_fix__3.4.1.patch.
fixed
NadiyaS
left a comment
NadiyaS
left a comment
There was a problem hiding this comment.
@magterskine please check all versions where this patch should be applied
mveeramneni
changed the title
- added file extension to patches.json file for BUNDLE-2554
mveeramneni
added
Progress: qa in progress
and removed
Progress: review
|
QA approved |
andriyShevtsov
added
Progress: approved
shiftedreality
dismissed
BarnyShergold’s stale review
Provided explanation for each
Fix for BUNDLE-2554 - Amzon-pay VBE module (Unable to switch credit card during checkout)
Description:
Fix for issue in Amazon-pay bundled extension in which error message is thrown when attempting to change payment card during amazon checkout flow
Fixed Issues (if relevant):
https://jira.corp.magento.com/browse/MCLOUD-5930
https://jira.corp.magento.com/browse/BUNDLE-2554
Manual testing scenarios
Ensure that customer can change from one saved payment card to another without error during amazon checkout flow
Negative test scenario
N/A
Contribution checklist
Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)
releasenotes
Fixes an issue with the Amazon Pay payment widget that prevented customers from changing the payment method on the Review & Payments step during the checkout process.