MCLOUD-5666: Assign every patch to modules it changes #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arhiopterecs
previously approved these changes
Apr 9, 2020
oshmyheliuk
previously approved these changes
Apr 9, 2020
YPyltiai
reviewed
Apr 10, 2020
| @@ -0,0 +1,50 @@ | |||
| <+>UTF-8 | |||
There was a problem hiding this comment.
@NadiyaS shouldn't this part be removed from https://github.com/magento/magento-cloud-patches/blob/7beeb00e34d607471c527b00cfe9d0803fbac04c/patches/MAGETWO-53941__fix_enterprise_paypal_codes__100.1.6.patch as you separated it?
Also, why we started adding encoding into patches? Never seen UTF-8 in patches before.
Contributor
Author
There was a problem hiding this comment.
@YPyltiai thank you for pointing this out. I did not push that commit where I removed this and updates in the patch for PP
oshmyheliuk
approved these changes
Apr 10, 2020
arhiopterecs
approved these changes
Apr 10, 2020
arhiopterecs
added
Progress: qa in progress
and removed
Progress: review
|
QA Approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assign patches for PayPal, Braintree and Authorize.net to appropriate Magento modules
Fixed Issues (if relevant)
Manual testing scenarios
There are 4 patches were unassigned from magento/magento2-base and assigned to modules they change:
A MAGETWO-53941__fix_enterprise_paypal_codes__100.1.6.patch for module-paypal
B. MC-31387__fix_paypal_issue_with_region__100.3.4.patch for module-paypal
C. MAGETWO-98129__transaction_field_is_removed_by_authorize_net__100.2.0.patch for module-autorizenet
D. MAGETWO-53941__fix_enterprise_braintree_code__100.1.6.patch for module-braintree
2.1.8, 2.2.0, 2.3.4
Contribution checklist
releasenotes
Updated patch assignment for payment method patches to target the payment modules instead of the Magento base package (
magento/magento2-base) so that the payment patches are applied only if the payment modules exist.