Skip to content

Conversation

@shiftedreality
Copy link
Member

@shiftedreality shiftedreality commented Feb 21, 2020

Description

Update for templates and guidelines.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

shiftedreality and others added 3 commits February 21, 2020 14:28
Co-Authored-By: Margaret Eker <meker@adobe.com>
Co-Authored-By: Margaret Eker <meker@adobe.com>
Co-Authored-By: Margaret Eker <meker@adobe.com>
Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix for the links to the Fork and PR instructions.

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the copy paste error for the Fork and PR link updates.

YPyltiai
YPyltiai previously approved these changes Feb 21, 2020
Co-Authored-By: Margaret Eker <meker@adobe.com>
@mveeramneni mveeramneni requested a review from meker12 February 24, 2020 16:14
@shiftedreality shiftedreality added the Progress: approved PR/issue status label Feb 24, 2020
@shiftedreality shiftedreality merged commit cde33df into develop Feb 24, 2020
@shiftedreality shiftedreality deleted the MAGECLOUD-5323 branch February 24, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Progress: approved PR/issue status

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants