Skip to content

Fix JSON syntax error on Magento_Amqp patches #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2020
Merged

Fix JSON syntax error on Magento_Amqp patches #25

merged 2 commits into from
Feb 18, 2020

Conversation

@PhantomDraven
Copy link
Contributor

@PhantomDraven PhantomDraven commented Feb 14, 2020 •
edited
Loading

Description

Last object in JSON must not have a 'comma'.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@PhantomDraven PhantomDraven reopened this Feb 14, 2020
@shiftedreality shiftedreality changed the base branch from develop to 1.0 February 14, 2020 15:30
@mveeramneni
Copy link

mveeramneni commented Feb 18, 2020

QA Approved

@shiftedreality shiftedreality merged commit 0630552 into magento:1.0 Feb 18, 2020
magento-cicd2 pushed a commit that referenced this pull request Apr 21, 2021
@viktym
MC-41912: 'magento-patches apply' command doesn't allow to apply some…
f1355ef 
… patches multiple times (#25)
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@PhantomDraven
Fix syntax error on composer.json of Magento_Amqp (#25)
16399b2
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@viktym
MC-41912: 'magento-patches apply' command doesn't allow to apply some…
afa9361 
… patches multiple times (#25)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bbatsche bbatsche bbatsche approved these changes

@NadiyaS NadiyaS NadiyaS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Progress: approved PR/issue status

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@PhantomDraven @mveeramneni @bbatsche @NadiyaS @shiftedreality @YPyltiai