MAGECLOUD-4458: De-compose All Patches from ECE-Tools #2
Conversation
src/Command/Patch/Manager.php
Outdated
| * | ||
| * @param OutputInterface $output | ||
| */ | ||
| public function copyStaticFile(OutputInterface $output) |
There was a problem hiding this comment.
Do we need this behavior here? It's not patch-related.
There was a problem hiding this comment.
You're right. Removed
|
@shiftedreality Did you make changes in |
|
It's going be separate PR to ece-tools |
| */ | ||
| public function create(array $cmd): Process | ||
| { | ||
| return new Process( |
There was a problem hiding this comment.
why commands are imploded by space?
There was a problem hiding this comment.
It is BC. Starting from Symfony/Process 4.2 it accepts only array
There was a problem hiding this comment.
then, maybe retrieve only first element and throw exception if there are more elements in array?
There was a problem hiding this comment.
That's the same method which Symfony does to preserve compatibility
| * | ||
| * @throws FileNotFoundException | ||
| */ | ||
| public function get(string $path): string |
There was a problem hiding this comment.
I would suggest renaming this method to getContent or getFileContent.
It's not obvious what is doing method get without reading method description.
|
QA approved |
…cloud-patches-78 [Imported] MC 37324: Add fallback to 'patch' command when 'git' command is not available
…cloud-patches-78 [Imported] MC 37324: Add fallback to 'patch' command when 'git' command is not available
Fixed issues
Related Pull Requests