Skip to content

MAGECLOUD-4982: De-composed magento-cloud-patches fail to apply locally #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2020
Merged

MAGECLOUD-4982: De-composed magento-cloud-patches fail to apply locally #15

merged 1 commit into from
Jan 12, 2020

Conversation

@billygilbert
Copy link

@billygilbert billygilbert commented Jan 10, 2020 •
edited
Loading

Description

Magento-Cloud-Patches fails to run when missing cloud specific files. Moved file generation to ece-tools
see PR: magento/ece-tools#663

Fixed Issues (if relevant)

  1. MAGECLOUD-4982

Manual testing scenarios

  1. Deploy to cloud, confirm pub/front-static.php is there and correct
  2. Run ece-tools patch locally, confirm works
  3. Run ece-patch apply locally, confrim works

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@billygilbert billygilbert mentioned this pull request Jan 10, 2020
Merged
4 tasks
@andriyShevtsov
Copy link
Collaborator

andriyShevtsov commented Jan 10, 2020

QA approved

@andriyShevtsov andriyShevtsov added Progress: approved PR/issue status and removed qa labels Jan 10, 2020
@billygilbert billygilbert merged commit 11e4fe7 into 1.0 Jan 12, 2020
@shiftedreality shiftedreality deleted the MAGECLOUD-4982 branch January 22, 2020 16:46
mmansoor-magento pushed a commit that referenced this pull request Jan 8, 2021
@dyushkin
MCLOUD-6923: Layered navigation filter is present only when product i… (
e95f66e 
#15)
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
Merge pull request #15 from magento/MAGECLOUD-4982
4476971 
MAGECLOUD-4982: De-composed magento-cloud-patches fail to apply locally
andriyShevtsov pushed a commit that referenced this pull request Sep 8, 2025
@dyushkin
MCLOUD-6923: Layered navigation filter is present only when product i… (
c5b65cd 
#15)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bbatsche bbatsche bbatsche approved these changes

@NadiyaS NadiyaS NadiyaS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Progress: approved PR/issue status Release Line: 1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@billygilbert @andriyShevtsov @bbatsche @NadiyaS