-
Notifications
You must be signed in to change notification settings - Fork 17
MCLOUD-6023: Investigate Redis scan keys eviction #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshmyheliuk
reviewed
Jul 14, 2020
| )); | ||
|
|
||
| $dbKeys = $this->run( | ||
| $cacheConfig['backend_options']['server'], |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you should check if $cacheConfig is an array and contains required keys?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
oshmyheliuk
previously approved these changes
Jul 14, 2020
bbatsche
previously approved these changes
Jul 14, 2020
kandy
suggested changes
Jul 14, 2020
ccee8c5
Contributor
|
QA approved |
kandy
previously approved these changes
Jul 15, 2020
bbatsche
previously approved these changes
Jul 15, 2020
bbatsche
previously approved these changes
Jul 15, 2020
oshmyheliuk
approved these changes
Jul 15, 2020
arhiopterecs
approved these changes
Jul 15, 2020
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 5, 2024
MCLOUD-12025 Cloud Tools Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per Redis (https://docs.redislabs.com/latest/ri/memory-optimizations/reclaim-expired-keys-memory-faster)
You can set up a cron job that runs the scan command after an interval which helps in reclaiming the memory of the expired keys.
A cron job should be created that will use the SCAN command with a COUNT parameter (value 10,000) that will run every 12 hours. Details can be found in the following links:
Fixed Issues (if relevant)
Manual testing scenarios
./bin/magento cache:evictfrom CLIrm -rf var/log/*'cache_evict' => ['enabled' => 1],inapp/etc/env.phpbin/magento cron:runcat var/log/system.log | grep "Keys scanned: "and see log entriesRelease notes
Added command
./bin/magento cache:evictto force run Redis Sync and evict expired keysAssociated documentation updates
Add link to Magento DevDocs PR or Issue, if needed.
Contribution checklist