Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Broken links: JavaScript Developer Guide #3251

Closed
jeff-matthews opened this issue Nov 7, 2018 · 1 comment · Fixed by #3268
Closed

Broken links: JavaScript Developer Guide #3251

jeff-matthews opened this issue Nov 7, 2018 · 1 comment · Fixed by #3268
Assignees
@jeff-matthews
Labels
2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff

Comments

@jeff-matthews
Copy link
Contributor

jeff-matthews commented Nov 7, 2018 •
edited
Loading

Bug report

Description

There are broken links to pages in the JavaScript Developer Guide.

Steps to reproduce

  1. Open the devdocs/rakelib/proofer.rb file.
  2. Delete javascript-dev-guide from the url_ignore array.
  3. Build the site.
  4. Run rake test:cicd and observe the following errors:
- linking to /guides/v2.1/javascript-dev-guide/javascript/custom_js.html#config_file, but config_file does not exist
        *  _site/guides/v2.1/javascript-dev-guide/javascript/js_practice.html (line 2107)
            <a href="/guides/v2.1/javascript-dev-guide/javascript/custom_js.html#config_file">can be reached from the page source view or from the file system</a>
    - linking to /guides/v2.2/javascript-dev-guide/javascript/custom_js.html#config_file, but config_file does not exist
        *  _site/guides/v2.2/javascript-dev-guide/javascript/js_practice.html (line 2167)
            <a href="/guides/v2.2/javascript-dev-guide/javascript/custom_js.html#config_file">can be reached from the page source view or from the file system</a>
    - linking to /guides/v2.3/javascript-dev-guide/javascript/custom_js.html#config_file, but config_file does not exist
        *  _site/guides/v2.3/javascript-dev-guide/javascript/js_practice.html (line 2212)
            <a href="/guides/v2.3/javascript-dev-guide/javascript/custom_js.html#config_file">can be reached from the page source view or from the file system</a>
@jeff-matthews jeff-matthews added Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies 2.x labels Nov 7, 2018
@jeff-matthews jeff-matthews self-assigned this Nov 7, 2018
@jeff-matthews jeff-matthews mentioned this issue Nov 7, 2018
Merged
4 tasks
@keharper
Copy link
Contributor

keharper commented Nov 7, 2018

Closed via #3268

@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Nov 16, 2018
magento-devops-reposync-svc pushed a commit that referenced this issue Aug 22, 2024
@dshevtsov @dependabot
Bump rexml from 3.3.4 to 3.3.6 (#3251)
3eefbf4 
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.4 to 3.3.6.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](ruby/rexml@v3.3.4...v3.3.6)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeff-matthews jeff-matthews

Labels
2.x Editorial Typo and grammar fixes or minor rewrites to correct inaccuracies Internal Dev Differentiates work between community and Magento staff
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix links: JavaScript Developer Guide magento/devdocs
2 participants
@keharper @jeff-matthews