MC-5465: Refactoring to use marketing edition labels in docs and options #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeff-matthews
approved these changes
Apr 29, 2019
paliarush
reviewed
Apr 30, 2019
| if ($overrideOriginalEdition !== 'open source' && $overrideOriginalEdition !== 'commerce') { | ||
| $opt = '--' . static::BASE_EDITION_OPT; | ||
| throw new InvalidOptionException("'$opt' accepts only 'community' or 'enterprise'"); | ||
| throw new InvalidOptionException("'$opt' accepts only 'Open Source' or 'Commerce'"); |
There was a problem hiding this comment.
Upper case and lower case seems to matter here.
There was a problem hiding this comment.
It doesn't; three lines up:
$overrideOriginalEdition = strtolower($overrideOriginalEdition);
paliarush
approved these changes
Apr 30, 2019
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Apr 12, 2022
Change plugin version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing mentions of "Community" and "Enterprise" in documentation and option inputs with "Open Source" and "Commerce".