MC-5465: Changing Console and WebSetupPluginInstaller classes to not be static #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paliarush
approved these changes
Apr 29, 2019
|
|
||
| /** | ||
| * @var bool|string $mageComposerBackup | ||
| * @var boolean|string $mageComposerBackup |
There was a problem hiding this comment.
Why this was changed? I think we should always use bool. There are more occurrences like this in this PR.
There was a problem hiding this comment.
I will change back to bool; other projects have both, so I just picked one to standardize here.
| use Symfony\Component\Console\Helper\HelperSet; | ||
| use Symfony\Component\Console\Helper\ProcessHelper; | ||
| use Symfony\Component\Console\Helper\QuestionHelper; | ||
| use Symfony\Component\Console\Input\ArrayInput; |
There was a problem hiding this comment.
This class now has a lot of dependencies, please consider splitting it. Same issue with other classes in this PR.
BTW, did we check this composer plugin with our sniffer and mess detector?
| use Magento\ComposerRootUpdatePlugin\Plugin\PluginDefinition; | ||
|
|
||
| /** | ||
| * Class WebSetupWizardPluginInstaller |
There was a problem hiding this comment.
Please do not keep auto-generated docs, either write good docs or remove the stubs.
magento-devops-reposync-svc
pushed a commit
that referenced
this pull request
Oct 18, 2021
PWA-2165: Move functionality to require-commerce and drop web setup w…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console and WebSetupPluginInstaller are now instantiated classes rather than static methods or singleton objects.