Skip to content

Conversation

@RuslanKostiv1
Copy link
Contributor

@RuslanKostiv1 RuslanKostiv1 commented Nov 12, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes ProductVariants Indexer Fix catalog-storefront#431

Questions or comments

Code Review Checklist (*)

See detailed checklist

  • Story AC is completed
  • proposed changes correspond to Magento Technical Vision
  • new or changed code is covered with web-api/integration tests (if applicable)
    • expected results in test verified with data from fixture
  • no backward incompatible changes
  • Export API (et_schema.xml) and SF API schemas (proto schema) are reflected in the codebase
    • prerequisite: story branch created with all needed generated classes according to proposes schema-changes
    • DTO classes do not contain any manual changes (Magento\CatalogExportApi*, Magento\CatalogStorefrontApi*)
  • Class usage: magento/catalog-storefront repo don't use directly classes from magento/saas-export repo and vise-verse
    • Check composer.json dependencies
  • Legacy code is deleted
    • Any Data Providers present in Connector part (Magento\CatalogStorefrontConnector, Magento*Extractor modules)
    • And Data Providers from Export API (magento/saas-export repo) that is not relevant anymore
    • Any DTO for Export API/SF API which does not reflect current schema: et_schema, proto schema
    • Any “mapper” on Message Broker (between Export API and SF API)
      • if mapper still needed, verify fields used in mapping, remove not relevant fields

jekabs and others added 6 commits November 11, 2020 21:46
@bricht
Copy link

bricht commented Nov 12, 2020

@magento run all tests

jekabs and others added 3 commits November 12, 2020 21:30
-Plugin fix
-Added a dependency in indexer for testing purposes
@bricht
Copy link

bricht commented Nov 13, 2020

@magento run WebAPI Tests

jekabs added 2 commits November 13, 2020 13:18
This reverts commit 5ef8cfe.
-Static test fixes
@bricht
Copy link

bricht commented Nov 13, 2020

@magento run Static Tests

-Slight cleanup
jekabs added 2 commits November 16, 2020 13:12
@bricht
Copy link

bricht commented Nov 16, 2020

@magento run all tests

@bricht
Copy link

bricht commented Nov 16, 2020

@magento run WebAPI Tests

-Syntax fixes
@bricht
Copy link

bricht commented Nov 16, 2020

@magento run Static Tests

@bricht
Copy link

bricht commented Nov 16, 2020

@magento run WebAPI Tests

1 similar comment
@bricht
Copy link

bricht commented Nov 16, 2020

@magento run WebAPI Tests

-Added indexer dependency
@bricht
Copy link

bricht commented Nov 16, 2020

@magento run WebAPI Tests

@RuslanKostiv1
Copy link
Contributor Author

@magento run all tests

This reverts commit e02f9bd.
@RuslanKostiv1
Copy link
Contributor Author

@magento import pr to magento-commerce/commerce-data-export

@magento-engcom-team
Copy link

@RuslanKostiv1 the pull request successfully imported.

@RuslanKostiv1
Copy link
Contributor Author

@magento run all tests

1 similar comment
@bricht
Copy link

bricht commented Nov 24, 2020

@magento run all tests

jekabs added 2 commits November 25, 2020 16:23
This reverts commit 65f3bab.
-WebAPI fix
@bricht
Copy link

bricht commented Nov 25, 2020

@magento run WebAPI tests

@bricht
Copy link

bricht commented Nov 25, 2020

@magento run WebAPI Tests

@bricht
Copy link

bricht commented Nov 26, 2020

@magento run all tests

@bricht bricht mentioned this pull request Nov 30, 2020
4 tasks
@mmansoor-magento mmansoor-magento merged commit 2d9d3fe into magento:main Dec 5, 2020
magento-devops-reposync-svc pushed a commit that referenced this pull request Nov 4, 2021
* MDEE-40:[Commerce Export] Implement stock_item_status feed
- cover with tests: basic cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ProductVariants Indexer Fix

4 participants