Change folder structure

Author: ovekeryk

.gitignore

@@ -0,0 +1 @@
+/.idea

Sniffs/Classes/Mysql4Sniff.php renamed to Magento1/Sniffs/Classes/Mysql4Sniff.php

@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
-<ruleset name="Ecg">
-    <description>ECG Coding Standard</description>
+<ruleset name="Magento1">
+    <description>Magento 1 Coding Standard</description>
 
     <rule ref="Generic.Classes.DuplicateClassName"/>
     <rule ref="Generic.CodeAnalysis.EmptyStatement"/>

Sniffs/Classes/ObjectInstantiationSniff.php renamed to Magento1/Sniffs/Classes/ObjectInstantiationSniff.php

@@ -0,0 +1,75 @@
+<?php
+
+class Magento2_Sniffs_Plugins_PluginSniff implements PHP_CodeSniffer_Sniff
+{
+
+    const PARAMS_QTY = 2;
+
+    const P_BEFORE = 'before';
+    const P_AROUND = 'around';
+    const P_AFTER = 'after';
+
+    protected $prefixes = array(
+        self::P_BEFORE,
+        self::P_AROUND,
+        self::P_AFTER
+    );
+
+    protected $exclude = array();
+
+
+    public function register()
+    {
+        return array(
+            T_FUNCTION
+        );
+    }
+
+
+    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+    {
+        $functionName = $phpcsFile->getDeclarationName($stackPtr);
+
+        $plugin = $this->startsWith($functionName, $this->prefixes, $this->exclude);
+        if ($plugin) {
+            $paramsQty = count($phpcsFile->getMethodParameters($stackPtr));
+            if ($paramsQty < self::PARAMS_QTY) {
+                $phpcsFile->addWarning('Plugin '.$functionName.' function should have at least two parameters.', $stackPtr);
+            }
+
+            if ($plugin == self::P_BEFORE) {
+                return;
+            }
+
+            $tokens = $phpcsFile->getTokens();
+
+            $hasReturn = false;
+            foreach ($tokens as $currToken) {
+                if ($currToken['code'] == T_RETURN && isset($currToken['conditions'][$stackPtr])) {
+                    $hasReturn = true;
+                    break;
+                }
+            }
+
+            if (!$hasReturn) {
+                $phpcsFile->addError('Plugin '.$functionName.' function must return value.', $stackPtr);
+            }
+        }
+    }
+
+
+    protected function startsWith($haystack, array $needle, array $excludeFunctions = array())
+    {
+        if (in_array($haystack, $excludeFunctions)) {
+            return false;
+        }
+        $haystackLength = strlen($haystack);
+        foreach ($needle as $currPref) {
+            $length = strlen($currPref);
+            if ($haystackLength != $length && substr($haystack, 0, $length) === $currPref) {
+                return $currPref;
+            }
+        }
+        return false;
+    }
+}

Sniffs/PHP/GotoSniff.php renamed to Magento1/Sniffs/PHP/GotoSniff.php

@@ -0,0 +1,34 @@
+<?php
+
+class Magento2_Sniffs_Templates_ThisInTemplateSniff implements PHP_CodeSniffer_Sniff
+{
+
+    protected $message = 'Usage of $this in template files is deprecated.';
+
+    protected $allowedMethods = array(
+        'helper',
+    );
+
+    public function register()
+    {
+        return array(
+            T_VARIABLE
+        );
+    }
+
+    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+    {
+        $tokens = $phpcsFile->getTokens();
+        if ($tokens[$stackPtr]['content'] == '$this') {
+            $endOfStatementPtr = $phpcsFile->findEndOfStatement($stackPtr);
+            $functionPtr = $phpcsFile->findNext(T_STRING, $stackPtr, $endOfStatementPtr);
+            if ($functionPtr) {
+                if (!in_array($tokens[$functionPtr]['content'], $this->allowedMethods)) {
+                    $phpcsFile->addWarning($this->message, $stackPtr);
+                }
+            } else {
+                $phpcsFile->addWarning($this->message, $stackPtr);
+            }
+        }
+    }
+}

Sniffs/PHP/NamespaceSniff.php renamed to Magento1/Sniffs/PHP/NamespaceSniff.php

@@ -0,0 +1,40 @@
+<?php
+namespace foo\bar;
+
+class TestPlugin
+{
+
+    public function before()
+    {
+        return '';
+    }
+
+
+    public function beforeSetName($subject, $name)
+    {
+        return array('(' . $name . ')');
+    }
+
+
+    public function afterGetName($subject, $result)
+    {
+        if (true) {
+            return 'hfwfwef';
+        }
+        return '|' . $result . '|';
+    }
+
+
+    public function aroundSave($subject, \Closure $proceed)
+    {
+        $this->doSmthBeforeProductIsSaved();
+        $returnValue = $proceed();
+        if ($returnValue) {
+            $this->postProductToFacebook();
+        }
+        return $returnValue;
+    }
+}
+
+$class = new TestPlugin();
+echo $class->go();

Sniffs/PHP/PrivateClassMemberSniff.php renamed to Magento1/Sniffs/PHP/PrivateClassMemberSniff.php

@@ -0,0 +1,45 @@
+<?xml version="1.0"?>
+<ruleset name="Magento2">
+    <description>Magento 2 Coding Standard</description>
+
+    <rule ref="Generic.Classes.DuplicateClassName"/>
+    <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
+    <rule ref="Generic.CodeAnalysis.ForLoopShouldBeWhileLoop"/>
+    <rule ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall"/>
+    <rule ref="Generic.CodeAnalysis.JumbledIncrementer"/>
+    <rule ref="Generic.CodeAnalysis.UnconditionalIfStatement"/>
+    <rule ref="Generic.CodeAnalysis.UnnecessaryFinalModifier"/>
+    <rule ref="Generic.CodeAnalysis.UnusedFunctionParameter"/>
+    <rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
+    <rule ref="Generic.Commenting.Fixme"/>
+    <rule ref="Generic.Commenting.Todo"/>
+    <rule ref="Generic.Files.ByteOrderMark"/>
+    <rule ref="Generic.Files.OneClassPerFile"/>
+    <rule ref="Generic.Files.OneInterfacePerFile"/>
+    <rule ref="Generic.Functions.CallTimePassByReference"/>
+    <rule ref="Generic.Metrics.CyclomaticComplexity"/>
+    <rule ref="Generic.Metrics.NestingLevel"/>
+    <rule ref="Generic.PHP.CharacterBeforePHPOpeningTag">
+        <exclude-pattern>*.phtml</exclude-pattern>
+    </rule>
+    <rule ref="Generic.PHP.DeprecatedFunctions"/>
+    <rule ref="Generic.PHP.NoSilencedErrors"/>
+    <rule ref="Generic.PHP.Syntax"/>
+
+    <rule ref="Squiz.Functions.GlobalFunction"/>
+    <rule ref="Squiz.Operators.IncrementDecrementUsage"/>
+    <rule ref="Squiz.PHP.DiscouragedFunctions"/>
+    <rule ref="Squiz.PHP.Eval"/>
+    <rule ref="Squiz.PHP.GlobalKeyword"/>
+    <rule ref="Squiz.PHP.NonExecutableCode"/>
+    <rule ref="Squiz.Scope.MethodScope"/>
+    <rule ref="Squiz.Scope.MemberVarScope"/>
+
+    <rule ref="Zend.Files.ClosingTag">
+        <exclude-pattern>*.phtml</exclude-pattern>
+    </rule>
+
+    <rule ref="Magento2.M2.ThisInTemplate">
+        <exclude-pattern>*.php</exclude-pattern>
+    </rule>
+</ruleset>

Sniffs/PHP/VarSniff.php renamed to Magento1/Sniffs/PHP/VarSniff.php

@@ -10,7 +10,6 @@
             "role": "Maintainer"
         }
     ],
-    "target-dir": "Ecg",
     "require": {
         "php": ">=5.4.0"
     }