Added new sniffs

Author: ovekeryk

Sniffs/PHP/NamespaceSniff.php

@@ -0,0 +1,40 @@
+<?php
+/**
+ * When catching an exception inside a namespace it is important that you escape to the global space.
+ *
+ */
+
+class Ecg_Sniffs_PHP_NamespaceSniff implements PHP_CodeSniffer_Sniff
+{
+    public function register()
+    {
+        return array(
+            T_CATCH
+        );
+    }
+
+    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+    {
+        if ($phpcsFile->findNext(T_NAMESPACE, 0) === false) {
+            return;
+        }
+
+        $tokens = $phpcsFile->getTokens();
+
+        $endOfTryStatement = $phpcsFile->findEndOfStatement($stackPtr);
+
+        $posOfCatchVariable = $phpcsFile->findNext(T_VARIABLE, $stackPtr, $endOfTryStatement);
+
+        $posOfExceptionClassName = $phpcsFile->findNext(T_STRING, $stackPtr, $posOfCatchVariable);
+
+        $posOfNsSeparator = $phpcsFile->findNext(T_NS_SEPARATOR, $stackPtr, $posOfExceptionClassName);
+
+        if ($posOfNsSeparator === false) {
+            $exceptionClassName = trim($tokens[$posOfExceptionClassName]['content']);
+            $posOfClassInUse = $phpcsFile->findNext(T_STRING, 0, $stackPtr, false, $exceptionClassName);
+            if ($posOfClassInUse === false || $tokens[$posOfClassInUse]['level'] != 0) {
+                $phpcsFile->addError('Namespace for "'.$exceptionClassName.'" class is not specified.', $posOfExceptionClassName);
+            }
+        }
+    }
+}

Sniffs/PHP/PrivateClassMemberSniff.php

@@ -0,0 +1,19 @@
+<?php
+/**
+ *
+ */
+
+class Ecg_Sniffs_PHP_PrivateClassMemberSniff implements PHP_CodeSniffer_Sniff
+{
+    public function register()
+    {
+        return array(
+            T_PRIVATE
+        );
+    }
+
+    public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr)
+    {
+        $phpcsFile->addWarning('Private class member detected.', $stackPtr);
+    }
+}

Tests/PHP/NamespaceUnitTest.inc

@@ -0,0 +1,19 @@
+<?php
+namespace foo\bar;
+
+//use \Exception;
+
+class TestNamespace
+{
+    public function go()
+    {
+        try {
+            throw new \Exception('test');
+        } catch (Exception $e) {
+            return 'cache block';
+        }
+    }
+}
+
+$class = new TestNamespace();
+echo $class->go();