-
Notifications
You must be signed in to change notification settings - Fork 150
Complete rewritten of the library #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…r sync to have https
@@ -0,0 +1 @@ | |||
// empty No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
print-color-adjust: exact; | ||
} | ||
} | ||
} No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
.state label:after, | ||
.state .icon { | ||
color-adjust: exact; | ||
/* stylelint-disable */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use //
comments everywhere
.state label:before, | ||
.state label:after, | ||
.state .icon { | ||
color-adjust: exact; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unknown property color-adjust
@@ -0,0 +1,13 @@ | |||
@media print { | |||
.#{$pretty--class-name} { | |||
.state:before, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Begin pseudo elements with double colons: ::
Selector should have depth of applicability no greater than 2, but was 3
|
||
input:checked ~ .state { | ||
&.p-on { | ||
opacity: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered display, opacity
display: inherit; | ||
} | ||
|
||
&.p-off .icon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector should have depth of applicability no greater than 2, but was 3
.icon, | ||
.svg, | ||
img { | ||
opacity: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered display, opacity
display: none; | ||
} | ||
|
||
&.p-off, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selector should have depth of applicability no greater than 2, but was 3
.#{$pretty--class-name}.p-toggle { | ||
.state { | ||
&.p-on { | ||
opacity: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Properties should be ordered display, opacity
Requested features
Lock ( #17 )
Bug fixes
z-index issue ( #6 ) ( #14 )
svg support ( #13 ) ( #16 )