Skip to content

Conversation

lokesh-coder
Copy link
Owner

Requested features

Lock ( #17 )

Bug fixes

z-index issue ( #6 ) ( #14 )
svg support ( #13 ) ( #16 )

@@ -0,0 +1 @@
// empty No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

print-color-adjust: exact;
}
}
} No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files should end with a trailing newline

.state label:after,
.state .icon {
color-adjust: exact;
/* stylelint-disable */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use // comments everywhere

.state label:before,
.state label:after,
.state .icon {
color-adjust: exact;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown property color-adjust

@@ -0,0 +1,13 @@
@media print {
.#{$pretty--class-name} {
.state:before,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Begin pseudo elements with double colons: ::
Selector should have depth of applicability no greater than 2, but was 3


input:checked ~ .state {
&.p-on {
opacity: 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, opacity

display: inherit;
}

&.p-off .icon {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

.icon,
.svg,
img {
opacity: 1;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, opacity

display: none;
}

&.p-off,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

.#{$pretty--class-name}.p-toggle {
.state {
&.p-on {
opacity: 0;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered display, opacity

@lokesh-coder lokesh-coder merged commit 7a61889 into staging Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants