Skip to content

[lldb] Add a missing <atomic> include. NFC. #162809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

[lldb] Add a missing <atomic> include. NFC. #162809

merged 1 commit into from
Oct 10, 2025

Conversation

@mstorsjo
Copy link
Member

@mstorsjo mstorsjo commented Oct 10, 2025

This fixes building LLDB for mingw with libstdc++, after 8ae30a3.

Previously, building errored out with errors like these:

In file included from llvm-project/lldb/include/lldb/Protocol/MCP/Transport.h:12,
                 from llvm-project/lldb/include/lldb/Protocol/MCP/Server.h:16,
                 from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:15,
                 from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp:9:
llvm-project/lldb/include/lldb/Host/JSONTransport.h:608:23: error: field ‘replied’ has incomplete type ‘std::atomic<bool>’
  608 |     std::atomic<bool> replied = {false};
      |                       ^~~~~~~
In file included from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/shared_ptr_atomic.h:33,
                 from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/memory:78,
                 from llvm-project/lldb/include/lldb/Host/Socket.h:12,
                 from llvm-project/lldb/include/lldb/Core/ProtocolServer.h:13,
                 from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:12:
gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/atomic_base.h:162:12: note: declaration of ‘struct std::atomic<bool>’
  162 |     struct atomic;
      |            ^~~~~~

@mstorsjo mstorsjo requested a review from ashgti October 10, 2025 09:05
@llvmbot llvmbot added the lldb label Oct 10, 2025
@llvmbot
Copy link
Member

llvmbot commented Oct 10, 2025

@llvm/pr-subscribers-lldb

Author: Martin Storsjö (mstorsjo)

Changes

This fixes building LLDB for mingw with libstdc++, after 8ae30a3.

Previously, building errored out with errors like these:

In file included from llvm-project/lldb/include/lldb/Protocol/MCP/Transport.h:12,
                 from llvm-project/lldb/include/lldb/Protocol/MCP/Server.h:16,
                 from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:15,
                 from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp:9:
llvm-project/lldb/include/lldb/Host/JSONTransport.h:608:23: error: field ‘replied’ has incomplete type ‘std::atomic&lt;bool&gt;’
  608 |     std::atomic&lt;bool&gt; replied = {false};
      |                       ^~~~~~~
In file included from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/shared_ptr_atomic.h:33,
                 from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/memory:78,
                 from llvm-project/lldb/include/lldb/Host/Socket.h:12,
                 from llvm-project/lldb/include/lldb/Core/ProtocolServer.h:13,
                 from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:12:
gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/atomic_base.h:162:12: note: declaration of ‘struct std::atomic&lt;bool&gt;’
  162 |     struct atomic;
      |            ^~~~~~

Full diff: https://github.com/llvm/llvm-project/pull/162809.diff

1 Files Affected:

  • (modified) lldb/include/lldb/Host/JSONTransport.h (+1)
diff --git a/lldb/include/lldb/Host/JSONTransport.h b/lldb/include/lldb/Host/JSONTransport.h
index 1453316e96fb4..29b40421575ac 100644
--- a/lldb/include/lldb/Host/JSONTransport.h
+++ b/lldb/include/lldb/Host/JSONTransport.h
@@ -35,6 +35,7 @@
 #include <utility>
 #include <variant>
 #include <vector>
+#include <atomic>
 #if __cplusplus >= 202002L
 #include <concepts>
 #endif

@github-actions
Copy link

github-actions bot commented Oct 10, 2025 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@mstorsjo
[lldb] Add a missing <atomic> include. NFC.
8983730 
This fixes building LLDB for mingw with libstdc++, after
8ae30a3.

Previously, building errored out with errors like these:

    In file included from llvm-project/lldb/include/lldb/Protocol/MCP/Transport.h:12,
                     from llvm-project/lldb/include/lldb/Protocol/MCP/Server.h:16,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:15,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp:9:
    llvm-project/lldb/include/lldb/Host/JSONTransport.h:608:23: error: field ‘replied’ has incomplete type ‘std::atomic<bool>’
      608 |     std::atomic<bool> replied = {false};
          |                       ^~~~~~~
    In file included from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/shared_ptr_atomic.h:33,
                     from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/memory:78,
                     from llvm-project/lldb/include/lldb/Host/Socket.h:12,
                     from llvm-project/lldb/include/lldb/Core/ProtocolServer.h:13,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:12:
    gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/atomic_base.h:162:12: note: declaration of ‘struct std::atomic<bool>’
      162 |     struct atomic;
          |            ^~~~~~
@mstorsjo mstorsjo force-pushed the lldb-missing-atomic branch from 31bf67e to 8983730 Compare October 10, 2025 09:10
DavidSpickett
DavidSpickett approved these changes Oct 10, 2025
View reviewed changes
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the "include what you use" basis, this LGTM.

@mstorsjo mstorsjo merged commit 31d2602 into llvm:main Oct 10, 2025
10 checks passed
@mstorsjo mstorsjo deleted the lldb-missing-atomic branch October 10, 2025 15:13
DharuniRAcharya pushed a commit to DharuniRAcharya/llvm-project that referenced this pull request Oct 13, 2025
@mstorsjo @DharuniRAcharya
[lldb] Add a missing <atomic> include. NFC. (llvm#162809)
c865cdc 
This fixes building LLDB for mingw with libstdc++, after
8ae30a3.

Previously, building errored out with errors like these:

    In file included from llvm-project/lldb/include/lldb/Protocol/MCP/Transport.h:12,
                     from llvm-project/lldb/include/lldb/Protocol/MCP/Server.h:16,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:15,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp:9:
    llvm-project/lldb/include/lldb/Host/JSONTransport.h:608:23: error: field ‘replied’ has incomplete type ‘std::atomic<bool>’
      608 |     std::atomic<bool> replied = {false};
          |                       ^~~~~~~
    In file included from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/shared_ptr_atomic.h:33,
                     from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/memory:78,
                     from llvm-project/lldb/include/lldb/Host/Socket.h:12,
                     from llvm-project/lldb/include/lldb/Core/ProtocolServer.h:13,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:12:
    gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/atomic_base.h:162:12: note: declaration of ‘struct std::atomic<bool>’
      162 |     struct atomic;
          |            ^~~~~~
akadutta pushed a commit to akadutta/llvm-project that referenced this pull request Oct 14, 2025
@mstorsjo @akadutta
[lldb] Add a missing <atomic> include. NFC. (llvm#162809)
59c2574 
This fixes building LLDB for mingw with libstdc++, after
8ae30a3.

Previously, building errored out with errors like these:

    In file included from llvm-project/lldb/include/lldb/Protocol/MCP/Transport.h:12,
                     from llvm-project/lldb/include/lldb/Protocol/MCP/Server.h:16,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:15,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.cpp:9:
    llvm-project/lldb/include/lldb/Host/JSONTransport.h:608:23: error: field ‘replied’ has incomplete type ‘std::atomic<bool>’
      608 |     std::atomic<bool> replied = {false};
          |                       ^~~~~~~
    In file included from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/shared_ptr_atomic.h:33,
                     from gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/memory:78,
                     from llvm-project/lldb/include/lldb/Host/Socket.h:12,
                     from llvm-project/lldb/include/lldb/Core/ProtocolServer.h:13,
                     from llvm-project/lldb/source/Plugins/Protocol/MCP/ProtocolServerMCP.h:12:
    gcc-mingw/x86_64-w64-mingw32/include/c++/12.1.0/bits/atomic_base.h:162:12: note: declaration of ‘struct std::atomic<bool>’
      162 |     struct atomic;
          |            ^~~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavidSpickett DavidSpickett DavidSpickett approved these changes

@ashgti ashgti Awaiting requested review from ashgti

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

Assignees

No one assigned

Labels

lldb

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mstorsjo @llvmbot @DavidSpickett