Audit/Update select uses in DiagnosticXKinds.td to use enum_select.

[erichkeane]

enum_select was added in this patch here: #122505

It is a really useful version of select that also creates an enum so that we don't have to use unreliable 'magic numbers'. However, the original patch touches one such diagnostic.

We need someone to audit all of our uses of select and see if:
1- the select has a significant number of items in it.
2- A lot of the uses of the select for the diagnostic in the source use a lot of magic numbers, OR an enum-made-just-for it

So if the diagnostic tends to have a lot of /* ThingIWantSelected */ 5 sort of things (or worse, just the 5!), it is likely a good candidate. Ones that are 'calculated' based on some other criteria aren't a great.

One such example is from: #120327 , which is what encouraged this patch.

Once we have ones identified, someone should then go through and convert these diagnostics.

[llvmbot]

Hi!

This issue may be a good introductory issue for people new to working on LLVM. If you would like to work on this issue, your first steps are:

1. Check that no other contributor has already been assigned to this issue. If you believe that no one is actually working on it despite an assignment, ping the person. After one week without a response, the assignee may be changed.
2. In the comments of this issue, request for it to be assigned to you, or just create a pull request after following the steps below. Mention this issue in the description of the pull request.
3. Fix the issue locally.
4. Run the test suite locally. Remember that the subdirectories under test/ create fine-grained testing targets, so you can e.g. use make check-clang-ast to only run Clang's AST tests.
5. Create a Git commit.
6. Run git clang-format HEAD~1 to format your changes.
7. Open a pull request to the upstream repository on GitHub. Detailed instructions can be found in GitHub's documentation. Mention this issue in the description of the pull request.

If you have any further questions about this issue, don't hesitate to ask via a comment in the thread below.

[llvmbot]

@llvm/issue-subscribers-good-first-issue

Author: Erich Keane (erichkeane)

`enum_select` was added in this patch here: https://github.com//pull/122505

It is a really useful version of select that also creates an enum so that we don't have to use unreliable 'magic numbers'. However, the original patch touches one such diagnostic.

We need someone to audit all of our uses of select and see if:
1- the select has a significant number of items in it.
2- A lot of the uses of the select for the diagnostic in the source use a lot of magic numbers, OR an enum-made-just-for it

So if the diagnostic tends to have a lot of /* ThingIWantSelected */ 5 sort of things (or worse, just the 5!), it is likely a good candidate. Ones that are 'calculated' based on some other criteria aren't a great.

One such example is from: #120327 , which is what encouraged this patch.

Once we have ones identified, someone should then go through and convert these diagnostics.

[ayokunle321]

Hey! Kinda new here and would like to work on this.

[erichkeane]

Hey! Kinda new here and would like to work on this.

Great, have fun! Let me know if you have troubles and I'll help how I can! Also, add me to the pull request once you have one.

[ayokunle321]

No p! Could I get assigned?

[shafik]

No p! Could I get assigned?

done

[amansharma612]

@ayokunle321 still working on this?

[ayokunle321]

@amansharma612 Nah, would you like to work on it?

[amansharma612]

@amansharma612 Nah, would you like to work on it?

Yes I can take a look