Fix parsing of keys containing literal []
inside bracket groups
#530
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
qs
splits bracket groups with a regex that forbids[]
inside a group:This causes keys like
search[withbracket[]]
to split into"[withbracket]"
, then"[]"
, leaving the inner[]
detached from the literal segment. Downstream, it can no longer be treated as a single literal key.Repro
Fix approach
Backport
splitKeyIntoSegments
from qs_dart and replace the regex child matcher with a balanced bracket splitter that treats[]
inside a bracket group as literal content (only outer[]
act as array push). This preserveswithbracket[]
as a single segment.Notes
[]
at the outermost level (array push).allowDots
,depth
,strictDepth
,allowPrototypes
, etc.Test snippet
Fixes #493