Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 2.7.5 #7

Merged
merged 4 commits into from
Feb 6, 2013
Merged

Upgrade to 2.7.5 #7

merged 4 commits into from
Feb 6, 2013

Conversation

dkarpenko
Copy link
Contributor

  • Upgrade of Tablesorter to 2.7.5
  • min.js files removed from gem
  • Patch version incremented only. Is patch update of Tablesorter minor update for jquery-tablesorter-rails ?

…ery-tablesorter.js by default attaches full versions; * they will be compressed by assets pipeline in production env)
@@ -40,7 +40,7 @@
/* white (unsorted) double arrow */
/* background-image: url(data:image/gif;base64,R0lGODlhFQAJAIAAAP///////yH5BAEAAAEALAAAAAAVAAkAAAIXjI+AywnaYnhUMoqt3gZXPmVg94yJVQAAOw==); */
/* image */
/* background-image: url(/assets/jquery-tablesorter/black-unsorted.gif); */
/* background-image: url(images/black-unsorted.gif); */
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run $ rake jquery_tablesorter:sanitize_image_paths to update image path?

https://github.com/linjunpop/jquery-tablesorter-rails#update-js-and-css-files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shame on me :(
Updated both submodule and CSSs

@linjunpop
Copy link
Owner

@dkarpenko Thanks. 🍻

linjunpop added a commit that referenced this pull request Feb 6, 2013
@linjunpop linjunpop merged commit 0eae812 into linjunpop:master Feb 6, 2013
@dkarpenko
Copy link
Contributor Author

You are welcome!

@dkarpenko dkarpenko deleted the upgrade_to_2_7_5 branch February 6, 2013 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants