Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for rails 4 #10

Merged
merged 1 commit into from
Mar 29, 2013
Merged

Support for rails 4 #10

merged 1 commit into from
Mar 29, 2013

Conversation

Intrepidd
Copy link
Contributor

In response to issue #8

Seems to work out of the box with only this gemspec change.

@linjunpop
Copy link
Owner

@Intrepidd, thank you. 🍻

Could you do s.add_dependency "railties", ">= 3.1, < 5"

That would be better, IMO.

@Intrepidd
Copy link
Contributor Author

There you go !

@@ -15,5 +15,5 @@ Gem::Specification.new do |s|

s.files = Dir["{vendor,lib}/**/*"] + ["MIT-LICENSE", "Rakefile", "README.markdown"]

s.add_dependency "railties", "~> 3.1"
s.add_dependency "railties", ">= 3.1, < 5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missing "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, fixing this right now

@Intrepidd
Copy link
Contributor Author

There you go for real !

@linjunpop
Copy link
Owner

@Intrepidd Thanks. 🍻

linjunpop added a commit that referenced this pull request Mar 29, 2013
Support for rails 4. Closes #8.
@linjunpop linjunpop merged commit 9fa80be into linjunpop:master Mar 29, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants