aes: explicit validation before TEE_FreeOperation call #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
How about fixing the problem by stepping up the used API? |
Contributor
|
Hi @jenswi-linaro, Could you please specify which TEE API should I use to replace the GP 1.1 compatibility mode. |
Contributor
|
Removing the |
Contributor
|
Please squash these changes into one commit. |
Author
|
Sure @jenswi-linaro. |
Contributor
|
Yes, please. The diff looks good. |
etienne-lms
reviewed
Oct 31, 2025
Remove CFG_TA_OPTEE_CORE_API_COMPAT_1_1=y to fix TA panic 0x0 from null handle operations. Change tag_len/out_len from uint32_t to size_t in auth_enc_op() to match modern TEE API function signatures for TEE_AEEncryptFinal and TEE_AEDecryptFinal. Fix format specifiers from %d to %zu for size_t variables to resolve compiler warnings. Signed-off-by: Amey Avinash Raghatate <ameyavinash.raghatate@amd.com>
Akshay-Belsare
force-pushed
the
ta_panic
branch
from
9cac705 to
e3c24ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add null checks before calling TEE_FreeOperation() to prevent TA panic when __OPTEE_CORE_API_COMPAT_1_1 is enable. The __GP11_TEE_FreeOperation() wrapper calls TEE_Panic(0) when passed TEE_HANDLE_NULL. Explicit validation ensures only valid handles reach the TEE API functions.
This resolves #144