Disallow control flow in if-expressions #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wcjohnson
reviewed
Jun 2, 2017
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "throws": "'return' outside of function (4:6)" | |||
| } | |||
There was a problem hiding this comment.
(Sorry if this is a duplicate, I tried to leave this comment and it somehow got sucked into the pattern matching discussion.)
I think people are going to be extremely confused by this error message, since the return is definitely not outside of a function. It should probably say something like: 'return' is not allowed in expressions.
This may be an upstream PR to babylon as well, since a doExpression should give that message as well.
There was a problem hiding this comment.
Yeah, agreed. Wasn't sure how best to do that. I guess a try/catch with rethrow would be easiest but that's a little ugly. Otherwise just add inExpression to state, which is more correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes if-expression behavior consistent with ES¿8? do-expression.