Better error message for missing class name #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rattrayalex
force-pushed
the
class-name-error
branch
from
7682c83 to
3a65cf4
Compare
|
Note that this isn't a lightscript-only change; the intent is to contribute upstream to Babylon |
|
Looks good! |
rattrayalex
changed the title
rattrayalex
force-pushed
the
class-name-error
branch
from
3a65cf4 to
0153209
Compare
|
Opened upstream PR at babel#509 |
rattrayalex
force-pushed
the
class-name-error
branch
from
0153209 to
b213b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses lightscript/lightscript#10
@wcjohnson thoughts?