Remove bitwise operators #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This shouldn't ship until the corresponding methods have been added to the stdlib |
|
IMO, this also shouldn't ship until lightscript/babel-plugin-lightscript#8 is fixed |
|
Yes, agreed
…On Mon, Apr 24, 2017, 18:46 William C. Johnson ***@***.***> wrote:
IMO, this also shouldn't ship until babel-plugin-lightscript/#8
<#8> is fixed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAq_LsfeRujDgz9Ap2kYZYzHwnit9zr3ks5rzVB9gaJpZM4NG4uq>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
&,|,^,<<,>>,>>>from the binary parsing algo with a slightly helpful error message.Frees them up for other purposes in a consistent fashion. Eg;
~(already appropriated) and|for pattern matching.No plans as of yet for
&or the bitshifts, I have an idea for^but not sure about it yet.