Allowed for psr/log 2.0 and 3.0 to be installed as well #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @boris-glumpler, thank you for doing this work. I'm just finishing up php-vips 2.0 (it gets rid of the annoying binary extension and uses php 7.4's FFI to call into libvips instead). Could we merge this PR as part of that? It should be finished in a few days (I hope). The branch is here, if you're curious: https://github.com/libvips/php-vips/tree/switch-to-php-ffi It runs most examples correctly, but a few tests still need fixing and it needs a bit of polish. |
|
Sorry, I hadn't actually read your PR. It's very simple, so I've just merged. I've merged it to the ffi branch as well, so it should be in 2.0. |
|
Yup, it's not exactly complicated ;) Cheers! Looking forward to v2.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for any current psr/log version to be installed. I did have to bump the PHP version to 7.2 because of partial contravariance. Tests are passing, but there might be an issue with phpdocumentor/phpdocumentor as it still requires psr/log v1. Wasn't sure how to handle that.
fixes #128