Skip to content

Fix packaging script when paths contain spaces #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2021
Merged

Fix packaging script when paths contain spaces #712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions script/repackage-dylibs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def note(msg)
TARGET_FRAMEWORKS_PATH = File.join(TARGET_BUILD_DIR, FRAMEWORKS_FOLDER_PATH)

def extract_link_dependencies(executable)
deps = `otool -L #{executable}`
deps = `otool -L "#{executable}"`

lines = deps.split("\n").map(&:strip)
lines.shift
Expand Down Expand Up @@ -92,7 +92,7 @@ def repackage_dependency(dep)
FileUtils.cp dep[:path], TARGET_FRAMEWORKS_PATH
FileUtils.chmod "u=rw", packaged_path

out = `install_name_tool -change #{dep.path} "@rpath/#{dep.name}" #{dep.executable}`
out = `install_name_tool -change "#{dep.path}" "@rpath/#{dep.name}" "#{dep.executable}"`
if $? != 0
err "install_name_tool failed with error #{$?}:\n#{out}"
end
Expand All @@ -107,7 +107,7 @@ def repackage_dependency(dep)

def fix_install_id(dep)
note "Fixing #{dep.name} install_name id…"
out = `install_name_tool -id @rpath/#{dep.name} #{dep.executable}`
out = `install_name_tool -id "@rpath/#{dep.name}" "#{dep.executable}"`
if $? != 0
err "install_name_tool failed with error #{$?}:\n#{out}"
end
Expand Down