Skip to content

Reorganized useEffect in accordion #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reorganized useEffect in accordion #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/components/accordion/Accordion.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,19 @@ function useAccordion() {
// We also pass second parameter to this function where we implement our own comparison
const AccordionPanel = React.memo(
props => {
console.log(props.label + " rendered");
const { label, onClick, isOpen, content } = props
console.log(label + " rendered");
const containerRef = useRef();

useEffect(() => {
if (props.isOpen) {
console.log(`scroll ${props.label} into view`);
scrollIntoView(containerRef.current, { block: 'nearest', scrollMode: 'if-needed' });
}
});
console.log(`scroll ${label} into view`);
scrollIntoView(containerRef.current, { block: 'nearest', scrollMode: 'if-needed' });
}, [isOpen]);

return (
<div onClick={props.onClick} ref={containerRef}>
<div className="accordion-label">{props.label}</div>
{props.isOpen && <div>{props.content}</div>}
<div onClick={onClick} ref={containerRef}>
<div className="accordion-label">{label}</div>
{isOpen && <div>{content}</div>}
</div>
);
}, // practically shouldComponentUpdate, but reversed
Expand Down