Helm chart labels and annotations and add missing image pull secrets in documentation #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
yonatankahana
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
yonatankahana
force-pushed
the
chart-labels-and-annotations
branch
from
de53e09 to
d2bc38e
Compare
Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
yonatankahana
force-pushed
the
chart-labels-and-annotations
branch
from
d2bc38e to
7412348
Compare
…al-provisioner into chart-labels-and-annotations
…in documentation Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
mkilchhofer
suggested changes
Mar 15, 2021
charts/nfs-subdir-external-provisioner/templates/deployment.yaml
Outdated
Show resolved
Hide resolved
k8s-ci-robot
added
the
approved
Signed-off-by: Yonatan Kahana <yonatankahana.il@gmail.com>
k8s-ci-robot
added
the
needs-rebase
mkilchhofer
approved these changes
Mar 22, 2021
mkilchhofer
suggested changes
Mar 22, 2021
Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
…al-provisioner into chart-labels-and-annotations
…na/nfs-subdir-external-provisioner into chart-labels-and-annotations
k8s-ci-robot
removed
the
needs-rebase
mkilchhofer
approved these changes
Apr 12, 2021
mkilchhofer
suggested changes
Apr 12, 2021
charts/nfs-subdir-external-provisioner/templates/storageclass.yaml
Outdated
Show resolved
Hide resolved
…s is false Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com>
k8s-ci-robot
added
the
needs-rebase
mkilchhofer
approved these changes
Apr 22, 2021
…r-external-provisioner into chart-labels-and-annotations
k8s-ci-robot
removed
the
needs-rebase
|
/cc @kmova |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kmova, mkilchhofer, yonatankahana The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63
Adds the ability to add custom labels to created resources
also adds the ability to add annotations to: storage class, pod and service account.
also, there was a missing documentation of image pull secrets that was exists but missing from values.yaml and readme.
the default labels should have been from
app.kubernetes.io/namespace and not justnameorreleaseby the best practices but it may breaks compatibility to someone and anywaymatchLabels(selectorLabels) are immutable once created so i gave up on that.the changes tested and are the it is upgrade-able and backward compatible.