Skip to content

Fixes Issue #172 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2022
Merged

Fixes Issue #172 #215

merged 2 commits into from
Aug 3, 2022
+6 −1

Conversation

@tinguin
Copy link
Contributor

@tinguin tinguin commented Jun 10, 2022

Added option to set the volumeBindingMode for StorageClass

@tinguin
There was no option to set the volumeBindingMode for the StorageClass.
aca10bf 
Added the option in
nfs-subdir-external-provisioner/charts/nfs-subdir-external-provisioner/templates/storageclass.yaml
and nfs-subdir-external-provisioner/charts/nfs-subdir-external-provisioner/values.yaml as well as updated charts/nfs-subdir-external-provisioner/README.md

This fixes Issue kubernetes-sigs#172
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 10, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tinguin / name: Florian Winkler (aca10bf)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 10, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 10, 2022

Welcome @tinguin!

It looks like this is your first PR to kubernetes-sigs/nfs-subdir-external-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/nfs-subdir-external-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 10, 2022
@tinguin
Copy link
Contributor Author

tinguin commented Jun 16, 2022

/assign @ashishranjan738

@gfnord
Copy link

gfnord commented Jul 13, 2022

Hi @ashishranjan738, please could you check the merge of this PR? Thanks buddy!

@ashishranjan738
Copy link
Contributor

ashishranjan738 commented Jul 14, 2022

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@tinguin
Copy link
Contributor Author

tinguin commented Aug 3, 2022

Hi yonatankahana, kmova, please have a look, would be great to get an approval for the code to be merged. Thank you!

@yonatankahana
Copy link
Contributor

yonatankahana commented Aug 3, 2022 •
edited
Loading

Hi yonatankahana, kmova, please have a look, would be great to get an approval for the code to be merged. Thank you!

Hi @tinguin,
please bump the charts version in Chart.yaml so merging the PR will trigger chart release with the changes.

@yonatankahana
Copy link
Contributor

yonatankahana commented Aug 3, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 3, 2022
@yonatankahana yonatankahana mentioned this pull request Aug 3, 2022
Closed
@tinguin
Copy link
Contributor Author

tinguin commented Aug 3, 2022

Hope i've done it right this time.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashishranjan738, tinguin, yonatankahana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ashishranjan738,yonatankahana]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yonatankahana
Copy link
Contributor

yonatankahana commented Aug 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit d080ea9 into kubernetes-sigs:master Aug 3, 2022
@tinguin tinguin mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmova kmova Awaiting requested review from kmova

1 more reviewer

@yonatankahana yonatankahana yonatankahana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashishranjan738 ashishranjan738

@yonatankahana yonatankahana

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tinguin @k8s-ci-robot @gfnord @ashishranjan738 @yonatankahana