✨ update CRD if already present #696

pires · 2019-11-26T15:57:40Z

In testenv, update the CRD if it's already present on the cluster instead of failing to continue.

Fixes #342
Closes #457

k8s-ci-robot · 2019-11-26T15:57:49Z

Welcome @pires!

It looks like this is your first PR to kubernetes-sigs/controller-runtime 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/controller-runtime has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2019-11-26T15:57:49Z

Hi @pires. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2019-11-26T16:02:33Z

@pires: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pkg/envtest/crd.go

alvaroaleman

/lgtm

DirectXMan12 · 2019-12-03T01:58:37Z

add a log line to this warning about it (and switch the title to say "update CRD if already present" to make it more likely that people'll notice it in the release notes), then I think we're good here.

I think it'd be fine even without, but better to provide feedback than give someone a debugging headache.

pires · 2019-12-03T10:14:09Z

Done, PTAL.

DirectXMan12 · 2019-12-06T01:16:40Z

did the test change disappear? I seem to recall that there was a change to the existing test here before...

otherwise lgtm

pires · 2019-12-06T11:31:28Z

Rebased master onto this branch and added a couple tests. I think there were no tests before, sorry for that.

Added tests:

Re-install unchanged CRDs
Install CRD with two versions; add a new version to CRD source; install CRD with three versions; ensure first install resulted in CRD with two versions while the second install resulted in same CRD name but with three versions.

pires · 2019-12-06T11:47:21Z

As is tradition around here, I forgot to include two new files and that's why I force-pushed. Need caffeine.

OK, I'll need help understanding why the second test fails. I tried it in many forms and haven't been able to get it to work. Also the tests usually yield different results on my side with MacOS 1.15.x, Go 1.13.5 and kind 0.6.1.

DirectXMan12 · 2019-12-09T23:11:28Z

As is tradition around here, I forgot to include two new files and that's why I force-pushed. Need caffeine.

heh, definitely had those days. Need a lint that checks if we've had caffeine yet for the day :-P

As for the test, did some poking around, and found the failure. It's another caffeine error :-P Commented inline.

pkg/envtest/crd.go

pkg/envtest/envtest_test.go

pires · 2019-12-11T18:30:53Z

Are we good @DirectXMan12?

pkg/envtest/crd.go

Signed-off-by: Pires <pjpires@gmail.com>

gerred · 2020-01-10T03:08:07Z

/lgtm

gerred · 2020-01-10T03:09:11Z

/approve

gerred · 2020-01-10T03:10:10Z

/assign @DirectXMan12

looks like everything has been addressed - I reviewed the code and nothing else stands out. thanks @pires

DirectXMan12 · 2020-01-14T01:25:08Z

Added a bit more of a PR description -- in general, I prefer to see a bit of a description beyond the bugs it fixes and the title, even if it's relatively minimal.

otherwise looks good :-)

/lgtm
/approve

k8s-ci-robot · 2020-01-14T01:25:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, gerred, pires

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [DirectXMan12]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

DirectXMan12 · 2020-01-14T01:25:52Z

Also, since this is a bit of a behavioral change, I've made it a feature instead of a bugfix, just to play it safe

pires · 2020-01-14T10:11:40Z

/retest

🏃 Download git-lfs directly on OSX

k8s-ci-robot requested review from droot and pwittrock November 26, 2019 15:57

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 26, 2019

pires changed the title ~~:patch: Don't error if the CRD is already present.~~ 🐛 Don't error if the CRD is already present. Nov 26, 2019

pires changed the title ~~🐛 Don't error if the CRD is already present.~~ :patch: Don't error if the CRD is already present Nov 26, 2019

pires force-pushed the pires/dont_error_if_crd_present branch from a4fcb71 to 8848476 Compare November 26, 2019 16:01

k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 26, 2019

pires changed the title ~~:patch: Don't error if the CRD is already present~~ 🐛 Don't error if the CRD is already present Nov 26, 2019

pires force-pushed the pires/dont_error_if_crd_present branch from 8848476 to 913d6ed Compare November 26, 2019 16:46

alvaroaleman reviewed Nov 29, 2019

View reviewed changes

pkg/envtest/crd.go Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 29, 2019

pires force-pushed the pires/dont_error_if_crd_present branch from 913d6ed to 6848bd2 Compare November 30, 2019 14:03

alvaroaleman approved these changes Nov 30, 2019

View reviewed changes

k8s-ci-robot assigned alvaroaleman Nov 30, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2019

pires changed the title ~~🐛 Don't error if the CRD is already present~~ 🐛 update CRD if already present Dec 3, 2019

pires force-pushed the pires/dont_error_if_crd_present branch from 6848bd2 to 25548b5 Compare December 3, 2019 10:13

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 3, 2019

pires force-pushed the pires/dont_error_if_crd_present branch from 25548b5 to 8b11cd9 Compare December 6, 2019 11:31

DirectXMan12 suggested changes Dec 9, 2019

View reviewed changes

pkg/envtest/crd.go Show resolved Hide resolved

DirectXMan12 reviewed Dec 9, 2019

View reviewed changes

pkg/envtest/envtest_test.go Show resolved Hide resolved

pires force-pushed the pires/dont_error_if_crd_present branch from c93b37f to d3247ac Compare December 10, 2019 15:39

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 10, 2019

pires force-pushed the pires/dont_error_if_crd_present branch 2 times, most recently from 79c06b1 to a0a84b7 Compare December 10, 2019 16:05

pires requested a review from DirectXMan12 January 3, 2020 14:03

DirectXMan12 suggested changes Jan 7, 2020

View reviewed changes

pkg/envtest/crd.go Show resolved Hide resolved

Update CRD if already present

5fc0586

Signed-off-by: Pires <pjpires@gmail.com>

pires force-pushed the pires/dont_error_if_crd_present branch from a0a84b7 to 5fc0586 Compare January 8, 2020 10:52

k8s-ci-robot assigned gerred Jan 10, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2020

k8s-ci-robot assigned DirectXMan12 Jan 10, 2020

gerred approved these changes Jan 10, 2020

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020

DirectXMan12 changed the title ~~🐛 update CRD if already present~~ ✨ update CRD if already present Jan 14, 2020

k8s-ci-robot merged commit 0d78900 into kubernetes-sigs:master Jan 14, 2020

pires deleted the pires/dont_error_if_crd_present branch January 14, 2020 11:15

DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020

Merge pull request #696 from DirectXMan12/infra/cache-homebrew

694d852

🏃 Download git-lfs directly on OSX

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ update CRD if already present #696

✨ update CRD if already present #696

pires commented Nov 26, 2019 •

edited by DirectXMan12

Loading

k8s-ci-robot commented Nov 26, 2019

k8s-ci-robot commented Nov 26, 2019

k8s-ci-robot commented Nov 26, 2019

alvaroaleman left a comment

DirectXMan12 commented Dec 3, 2019

pires commented Dec 3, 2019

DirectXMan12 commented Dec 6, 2019

pires commented Dec 6, 2019 •

edited

Loading

pires commented Dec 6, 2019 •

edited

Loading

DirectXMan12 commented Dec 9, 2019

pires commented Dec 11, 2019

gerred commented Jan 10, 2020

gerred commented Jan 10, 2020

gerred commented Jan 10, 2020

DirectXMan12 commented Jan 14, 2020

k8s-ci-robot commented Jan 14, 2020

DirectXMan12 commented Jan 14, 2020

pires commented Jan 14, 2020

✨ update CRD if already present #696

✨ update CRD if already present #696

Conversation

pires commented Nov 26, 2019 • edited by DirectXMan12 Loading

k8s-ci-robot commented Nov 26, 2019

k8s-ci-robot commented Nov 26, 2019

k8s-ci-robot commented Nov 26, 2019

alvaroaleman left a comment

Choose a reason for hiding this comment

DirectXMan12 commented Dec 3, 2019

pires commented Dec 3, 2019

DirectXMan12 commented Dec 6, 2019

pires commented Dec 6, 2019 • edited Loading

pires commented Dec 6, 2019 • edited Loading

DirectXMan12 commented Dec 9, 2019

pires commented Dec 11, 2019

gerred commented Jan 10, 2020

gerred commented Jan 10, 2020

gerred commented Jan 10, 2020

DirectXMan12 commented Jan 14, 2020

k8s-ci-robot commented Jan 14, 2020

DirectXMan12 commented Jan 14, 2020

pires commented Jan 14, 2020

pires commented Nov 26, 2019 •

edited by DirectXMan12

Loading

pires commented Dec 6, 2019 •

edited

Loading

pires commented Dec 6, 2019 •

edited

Loading