Rename application package to builder #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
droot
reviewed
Jun 28, 2018
| limitations under the License. | ||
| */ | ||
|
|
||
| // Package builder provides wraps other controller-runtime libraries and exposes simple |
| // An application is a Controller that implements the operational logic for an application. It is often used | ||
| // to take off-the-shelf OSS applications, and make them Kubernetes native. | ||
| // Application Controllers are most useful for stateful applications such as Cassandra, Etcd and MySQL | ||
| // which contain operation logic for sharding, backup and restore, upgrade / downgrade, etc. | ||
| package application |
There was a problem hiding this comment.
We are keeping this around ?
There was a problem hiding this comment.
Just for documentation
pwittrock
added
approved
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
pwittrock
added
the
lgtm
justinsb
pushed a commit
to justinsb/controller-runtime
that referenced
this pull request
Dec 7, 2018
Rename application package to builder
DirectXMan12
pushed a commit
that referenced
this pull request
Jan 31, 2020
standardize kubebuilder codegeneration labels to have +kubebuilder: prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.