✨ envtest: add option to download binaries, bump envtest to v1.32.0 #3135
+596
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
sbueringer
force-pushed
the
pr-envtest-dl-binaries
branch
3 times, most recently
from
8319e6e to
1afd234
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
10 tasks
|
/hold Waiting for initial feedback, I'll add test coverage later |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Stefan Büringer buringerst@vmware.com
sbueringer
force-pushed
the
pr-envtest-dl-binaries
branch
from
1afd234 to
4a70d59
Compare
alvaroaleman
reviewed
Mar 2, 2025
| DownloadBinaryAssets bool | ||
|
|
||
| // DownloadBinaryAssetsVersion is the version of envtest binaries to download. | ||
| DownloadBinaryAssetsVersion string |
There was a problem hiding this comment.
We could maybe default this to the latest version?
There was a problem hiding this comment.
I might be blind but I don't see it?
There was a problem hiding this comment.
Sorry, pushed just now :)
(was sort of implied "with the next push", had to implement unit tests, took a bit)
k8s-ci-robot
added
size/XL
|
@alvaroaleman Should be fixed + added test coverage /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
alvaroaleman
approved these changes
Mar 2, 2025
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 71e08d42cda79e39617a26fe54fdd05ca7317224
|
alvaroaleman
added
the
tide/merge-method-squash
10 tasks
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 13, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 13, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 14, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 14, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 17, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
tomasaschan
added a commit
to tomasaschan/kro
that referenced
this pull request
Mar 19, 2025
This relies on yet unreleased features of controller-runtime, but it will we'll be able to roll forward to the next patch release as soon as one that contains both kubernetes-sigs/controller-runtime#3135 and kubernetes-sigs/controller-runtime#3137 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer buringerst@vmware.com