-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Svelte to v3.2.0 #557
Conversation
Thanks a lot! |
I think we're missing something here, @Rich-Harris. |
@frederikhors How so? The performance gain not as much as you expected? The array reconciliation API hadn't changed as far as I could tell so that part stayed the same from implementation standpoint. Admittedly I've never touched Svelte before doing this implementation so I may have missed something. My understanding was most of the improvements were in syntax (way cleaner I think there is only 1 or 2 libraries that do the benchmark with less implementation code) and bundle size (shaved a whole kilobyte on the implementation). Although I'd obviously love to hear Rich's thoughts. |
@frederikhors @Rich-Harris |
|
@deklanw @Rich-Harris @frederikhors I might lean towards "Less Code" simply because I feel explicit Event Delegation might butcher the aesthetics of the implementation, and will only improve performance a certain amount. There are other optimizations of list reconcilliation and element creation employed at the library level that make more of a difference. If we don't hear from Rich, I will take consensus here. But I have no problem doing a few tweaks to get the performance up. |
@ryansolid For what it's worth I'm on the performance side. I think @Rich-Harris will come soon here. |
Yeah if nothing by the weekend I will add event delegation. I wrote a medium article talking about writing this implementation and experience with Svelte. https://medium.com/@ryansolid/javascript-ui-compilers-comparing-svelte-and-solid-cbcba2120cea. Maybe this will draw someone more involved with the project out. |
As requested on #553.
I'm not sure performance is any better. I didn't witness that. But on positive the new syntax really was delightful. Idiomatic array updates using spreads like immutable libraries and the bindings more inline with JSX. Really I can only think of a library or 2 that achieve the same with less written code.