-
Notifications
You must be signed in to change notification settings - Fork 118
Correction: Fix Browser import statement #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
byteshiva
wants to merge
21
commits into
kotlin-hands-on:step-07-using-external-rest-api
from
byteshiva:patch-1
Closed
Correction: Fix Browser import statement #7
byteshiva
wants to merge
21
commits into
kotlin-hands-on:step-07-using-external-rest-api
from
byteshiva:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update kotlin and reactjs.
Use styled components Add Video data class and example lists for unwatched and watched videos
Introduce VideoList component with selection mechanism (state and properties)
Pass video selection handlers to video list
Add "Mark as (un)watched" button to video player Move (un)watched videos to AppState
Introduce VideoList component with selection mechanism (state and properties)
Pass video selection handlers to video list
Add "Mark as (un)watched" button to video player Move (un)watched videos to AppState
Use react-player in video player Add Email and Telegram share buttons to video player
Introduce VideoList component with selection mechanism (state and properties)
Update Gradle to 6.6 Update dependency versions to 1.4-compatible libraries Add explicit versions to NPM dependencies Use new Gradle DSL for configuring Kotlin/JS Move kotlin.browser to kotlinx.browser
# Conflicts: # src/main/kotlin/Main.kt
# Conflicts: # src/main/kotlin/App.kt # src/main/kotlin/VideoList.kt
# Conflicts: # src/main/kotlin/VideoList.kt # src/main/kotlin/VideoPlayer.kt
Fix browser import statement
e8e7ac2 to
683f92c
Compare
683f92c to
1c29343
Compare
Member
|
Thank you for your contribution – these changes have been addressed in the latest version of the tutorial! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix browser import statement