Skip to content

Conversation

@satbot
Copy link
Contributor

@satbot satbot commented Feb 6, 2020

Checklist

Description

"No contribution is too small", I fixed a single character typo in the Heap Sort README. (First open source contribution ever 🙂)

@hollance
Copy link
Member

hollance commented Feb 6, 2020

It's not really a typo. 😄 lg is often used as shorthand for log_2, while log is more ambiguous (is it log_10, log_2, or the natural logarithm?).

@satbot
Copy link
Contributor Author

satbot commented Feb 6, 2020

It's not really a typo. 😄 lg is often used as shorthand for log_2, while log is more ambiguous (is it log_10, log_2, or the natural logarithm?).

Oh wow I actually did not know that, at least I learned something from this process 😁

@hollance while I now recognise that lg is technically correct, I still think that it should be changed to log since the base 2 can be considered a constant factor which is "not important and can be omitted" from big O notation.

However, I'm happy for this to be closed if it seems unnecessary.

@kelvinlauKL
Copy link
Member

Seems fair 👍

@kelvinlauKL kelvinlauKL merged commit c22182f into kodecocodes:master Feb 14, 2020
@satbot satbot deleted the heapsort-typo branch February 25, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants