Insersion sort: rename variables with convenience names #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ash
reviewed
Aug 25, 2019
Contributor
richard-ash
left a comment
richard-ash
left a comment
There was a problem hiding this comment.
Cool thanks for the update 😄
Couple small stylistic comments otherwise looks good!
| while y > 0 && a[y] < a[y - 1] { // 3 | ||
| a.swapAt(y - 1, y) | ||
| y -= 1 | ||
| var sortedArray = array // 1 |
Contributor
There was a problem hiding this comment.
Can we keep the // 1, // 2, etc vertical with each other?
Contributor
Author
There was a problem hiding this comment.
could you clarify what you mean by making them vertical
| var currentIndex = index | ||
| let temp = sortedArray[currentIndex] | ||
| while currentIndex > 0 && temp < sortedArray[currentIndex - 1] { | ||
| sortedArray[currentIndex] = sortedArray[currentIndex - 1] // 1 |
Contributor
|
Thanks for the updates! The last two comments still need updating then I'll merge 🙂 |
Contributor
Author
|
Hi Richard, I will complete it today, thanks
…On Fri, 6 Sep 2019 at 07:36, Richard Ash ***@***.***> wrote:
Thanks for the updates! The last two comments still need updating then
I'll merge 🙂
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#887>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABK4BWV33I3IY3SH4DIW24LQIHT55ANCNFSM4IL5YGAQ>
.
--
<https://about.me/abuzeidibrahim?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb>
Abuzeid Ibrahim
<https://about.me/abuzeidibrahim?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb>Software
Engineer
Mobile: +2 01061933229
linkedin.com/in/abuzeid-ibrahim
github.com/abuzeid-ibrahim
about.me/abuzeidibrahim
<https://about.me/abuzeidibrahim?promo=email_sig&utm_source=product&utm_medium=email_sig&utm_campaign=gmail_api&utm_content=thumb>
|
Contributor
Author
|
Hi, I don't understand why the Pr still open till now :( |
richard-ash
approved these changes
Aug 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description